Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing positon arguments #28

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

shun2wang
Copy link
Contributor

So, there were some error because %s and%1$s pointing to same postion in a gettextf(). then will lost some arguments outputs.unfortunately i dont how to catch this warning automatically?

For example:

sprintf("A design with %s will reliably (with probability greater than %1$s) detect  %2$s%3$s.","","","","")

get:

>>"A design with 零 will reliably (with probability greater than 零) detect  一二."
Warning message:
In sprintf("A design with %s will reliably (with probability greater than %1$s) detect  %2$s%3$s.",  :
  one argument not used by format......

@shun2wang shun2wang requested a review from boutinb September 27, 2023 07:56
@shun2wang
Copy link
Contributor Author

failed i18n check has been fix on weblate. so not related this PR.

@boutinb boutinb merged commit 48d1015 into jasp-stats:master Sep 27, 2023
1 of 5 checks passed
@shun2wang shun2wang deleted the fixTranslationStrings branch September 27, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants