Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSA updates #323

Merged
merged 19 commits into from
Aug 23, 2024
Merged

MSA updates #323

merged 19 commits into from
Aug 23, 2024

Conversation

JTPetter
Copy link
Contributor

  • Updated gauge r&R non. rep. help file.
  • Gauge r&R linearity change default value of process variation to 1.
  • Fix capitalization, aligned naming, and changed option names as suggested by Rene.
  • Type1 Study: Changing percent of tolerance for Cg now affects boundaries displayed in plot.
  • Type 1 Study: Added tolerance bounds to table.
  • Type 1 Study: Added mean and three sigma limits to run chart.
  • Type 1 Study: Added option to select left- or right-open bins and centered bins on integers.
  • Gauge r&R Crossed: Changed order of variance components to display operator x part before part-to-part.
  • Gauge r&R Crossed: Fixed bug where variance component table would display empty cells when historical std. dev. was used.
  • Gauge r&R Nested: Implemented traffic light chart for regular output and report.
  • Gauge r&R Crossed & Nested: Fixed crash of range chart and average chart per operator if only on measurement per part was supplied.
  • Gauge Linearity: Changed order of Std. Error and t-statistic in regression table.
  • Gauge Linearity: Added regression equation to output and made percent process variation graph in JASP style.
  • Gauge r&R crossed and nested: Added gauge evaluation tables and number of distinct categories to report
  • Gauge r&R crossed: Made more robust towards input that has no repeated measurements.
  • Gauge r&R nested: Fixed calculation to always recognize nested structure.
  • All MSA: Added error messages for missing values that crash analyses.
  • Attribute Agreement: Fix crash when no standards were provided.
  • Added verified unit tests.

The large number of changed lines is related to the updated unit tests (many new plot files).

@JTPetter JTPetter requested a review from vandenman July 17, 2024 15:29
Copy link
Contributor

@vandenman vandenman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments below. Also, it's easier to review multiple smaller PRs than one big one!

R/msaGaugeLinearity.R Outdated Show resolved Hide resolved
inst/qml/msaGaugeRR.qml Outdated Show resolved Hide resolved
inst/qml/msaGaugeRRnonrep.qml Outdated Show resolved Hide resolved
JTPetter and others added 3 commits July 19, 2024 14:18
Co-authored-by: Don van den Bergh <[email protected]>
Co-authored-by: Don van den Bergh <[email protected]>
Co-authored-by: Don van den Bergh <[email protected]>
@JTPetter JTPetter requested a review from vandenman July 19, 2024 12:20
@JTPetter
Copy link
Contributor Author

Thanks - will try to make smaller PRs whenever possible.

@JTPetter
Copy link
Contributor Author

JTPetter commented Aug 9, 2024

Added fix for jasp-stats/jasp-issues#2867

@vandenman vandenman merged commit d8e0d61 into jasp-stats:master Aug 23, 2024
5 checks passed
@JTPetter JTPetter deleted the msaUpdates branch August 23, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants