Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special control charts #332

Merged
merged 25 commits into from
Oct 7, 2024
Merged

Special control charts #332

merged 25 commits into from
Oct 7, 2024

Conversation

JTPetter
Copy link
Contributor

@JTPetter JTPetter requested a review from vandenman September 18, 2024 14:41
@JTPetter
Copy link
Contributor Author

@vandenman Excuses for the big PR, but I could not find a good way of splitting this (without submitting something that is not functional). But most lines and files are related to the plots in the unit tests anyways, so not quite as big as it might appear.

@JTPetter
CUSUM chart
1e51e66
@JTPetter
Cusum chart final features
4ff6265
@JTPetter
ewma chart
6ac39e6
@JTPetter
GUI and r code start for rare event charts
e838718
@JTPetter
Date and time format processing
f6f9eca
@JTPetter
g chart functionality
b26a2aa
@JTPetter
t chart functionality
a3fe87b
@JTPetter
historical parameters and handling 0s in weibull
62b6a61
@JTPetter
helpfile attribute charts
1a0847a
@JTPetter
Report functionality time weighted and rare event charts
89f06e9
@JTPetter
Fix dependencies
70a2ff9
@JTPetter
Help file time weighted charts
a24931c
@JTPetter
Rare event charts help file
0a4bc6f
@JTPetter
Setup for time weighted and rare event chart unit tests
d3b7f76
@JTPetter
Start unit tests
dd327f6
@JTPetter
Fix for issue 2895
4293237
@JTPetter
Time weighted charts unit tests LF
d61c332
@JTPetter
Unit tests time weighted charts wide format
07453d4
@JTPetter
Start unit tests for rare event charts
c5d5831
@JTPetter
Rare event charts unit tests continued
f4adba2
@JTPetter
Finalize rare event chart unit tests
32d805c
@JTPetter
Error handling negative values
13d2f05
@JTPetter
fix unit tests
73fd355
@JTPetter
Skip test that fails only on Mac
94d6eec
@JTPetter JTPetter force-pushed the specialControlCharts branch from c2a1222 to 94d6eec Compare September 20, 2024 14:45
vandenman
vandenman requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@vandenman vandenman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, some minor comments below

R/rareEventCharts.R Outdated Show resolved Hide resolved
R/rareEventCharts.R Outdated Show resolved Hide resolved
R/rareEventCharts.R Show resolved Hide resolved
R/commonQualityControl.R Show resolved Hide resolved
R/commonQualityControl.R Outdated Show resolved Hide resolved
R/commonQualityControl.R Outdated Show resolved Hide resolved
inst/qml/rareEventCharts.qml Show resolved Hide resolved
@JTPetter
Copy link
Contributor Author

JTPetter commented Oct 3, 2024

@vandenman Thanks! I have addressed your feedback.

@JTPetter JTPetter requested a review from vandenman October 3, 2024 08:55
@vandenman vandenman merged commit 7d5018c into jasp-stats:master Oct 7, 2024
5 checks passed
@JTPetter JTPetter deleted the specialControlCharts branch October 9, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandenman vandenman vandenman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JTPetter @vandenman