Values for LSL, USL, target labels and unit tests updates #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JTPetter
commented
Sep 26, 2024
JTPetter
commented
- Added the specified value to the USL, LSL and target labels in the process capability plot.
vandenman
approved these changes
Oct 7, 2024
|
can you resolve the conflicts? you probably need to rebase and recreate the two figures |
JTPetter
force-pushed
the
pcsChartLabels
branch
from
da90a87 to
048443e
Compare
|
@vandenman I rebased. The unit tests are fine for me locally, not sure why they fail on GitHub. There is also this message "There was a problem generating the rebase commit". Would you happen to know how to fix this? |
|
Okay "Squash and merge" would work, if we would go ahead despite the unit tests |
JTPetter
force-pushed
the
pcsChartLabels
branch
from
048443e to
862cb10
Compare
|
Fixed the unit tests, so I will merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.