-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semi parametric survival analysis (Cox proportional hazards) #5
Conversation
@boutinb there are couple of qml bugs with the height of |
why can this PR actually be merged without my approval? Shouldn't there be securities that there needs to be some contingency? |
I think the name "semiparametric" sounds good |
So when I choose Counting with the Rossi.csv data, the GUI fucks up. Same with the RossiLong data |
When Method=Exact and some variable is put in Cluster, I get an not very informative error: |
Another error, the tables are all empty for the specific combination of options: |
the hazard estimation table shows weird numbers for this |
I dont get why the Plot has Options Legend and Color Palette. For me, I do not see a legend nor colors. It's a grey plot. Maybe I am misunderstanding something. |
I get some plot errors with this: |
where are the tests? and where are the help files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite the big PR, nice work, especially coding the conditions in qml as a function. I am going to steal that!
all but the UI is fixed now |
did you check all these errors. Cause this one seems to be still there for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of it seems fine, but not all :)
fixed the remaining issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should start working with the info stuff in qml, nice.
The last error is fixed for me. Not sure about the description file, did ou update the version? Although, most of my modules are a bit behind either...
add basics of semiparametric model
Co-authored-by: Julius Pfadt <[email protected]>
938e337
to
5793f9f
Compare
adds semi-parametric survival analysis
Should the analysis be called "Cox proportional hazards" or "Semiparametric"
(later we will add "parametric models" (under a single umbrella because they can have many different likelihoods, similar to glms)
links: jasp-stats/jasp-issues#206 (does not add Bayesian versions)
the proper qml display requires commits pos 19.1
plotting completely switched from survminer to ggsurvfit due to a) patchwork and better flexibility
some nice data sets for testing:
Rossi.csv
Rossi.long.csv --- can be used for the counting input
bladder.csv