Prepare build for JDK24+ #1666
Merged
Prepare build for JDK24+ #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
matthiasblaesing
commented
Apr 22, 2025
matthiasblaesing
commented
- enable running CI/CD matrix on JDK24 (dropping JDK23 for this)
- adjust build script to set parameters so that unittests run without warnings from native access
- enable running CI/CD matrix on JDK24 (dropping JDK23 for this) - adjust build script to set parameters so that unittests run without warnings from native access
dbwiddis
approved these changes
Apr 22, 2025
.github/workflows/ci.yaml
Outdated
| @@ -16,7 +16,7 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| strategy: | |||
| matrix: | |||
| java: [8, 11, 17, 21, 23] | |||
| java: [8, 11, 17, 21, 24] | |||
| # macos-13 is x86, macos-latest is aarch64 | |||
| os: [ubuntu-latest, macos-13, macos-latest] | |||
There was a problem hiding this comment.
While we're updating the matrix, a few things:
- We should consider adding ubuntu-24.04-arm to get ARM coverage on Linux. (The macos-latest gets Apple Silicon while -13 is x86.) See https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
- We might consider defining some combinations to cover all JDKs and all OS platforms without doing every possible combination (4 x 5 = 20). All OS's combos on the latest JDK seems sane but maybe spread the 4 other JDKs over 4 os's for a total of 8 runs?
There was a problem hiding this comment.
How about:
- java: [8, 21, 24]
- os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, maxos-13]
Idea here:
- cover the lower end of the supported spectrum (JDK 8)
- cover the current LTS
- cover the current Java version
At this point in time, I don't see many things breaking on JDK 11/17, that will work both on JDK 8 and 21.
- cover the lower end of the supported spectrum (JDK 8) - cover the current java LTS - cover the current Java version on - linux x86-64 - linux aarch64 - mac OS x86-64 - mac OS aarch64 Fixing the number of tests to 12.
dbwiddis
approved these changes
Apr 23, 2025
|
@dbwiddis thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.