Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

WIP: JDK-8208649 - FXCanvas / JFXPanel: Windows opened are not children of the SWT/Swing Window #145

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tomsontom
Copy link
Contributor

This is a first PoC on passing the native pointer from SWT to JavaFX to see if this can be done and would work. Currently this is just hacked into the OS-X Version but if @kevinrushforth agrees that this would be feasable the next step would be to get this working on Linux and Windows and improve the implementation.

The following things need to be considered:

  • what happens to sub-windows if the JFXPanel/FXCanvas is reparented on to another window. Do we need to reparent them as well or would be ok to just close them?
  • find out why the color-picker popup initially moves but if you hover on it, it repositions on the old coordinates

@kevinrushforth
Copy link
Collaborator

Filed in JBS as JDK-8208649

@eugener eugener added bug Something isn't working WIP Work In Progress Experiment Experimental changes, not intented for merge labels Aug 4, 2018
@kevinrushforth kevinrushforth changed the title [WiP] Jdk 8208649 - FXCanvas / JFXPanel: Windows opened are not children of the SWT/Swing Window WIP: JDK-8208649 - FXCanvas / JFXPanel: Windows opened are not children of the SWT/Swing Window Oct 1, 2019
@kevinrushforth
Copy link
Collaborator

kevinrushforth commented Oct 1, 2019

As announced in this message, the official jfx repository is moving from hg.openjdk.java.net/openjfx/jfx-dev/rt to github.com/openjdk/jfx.

This sandbox repository is being retired on 1-Oct-2019. You will need to migrate your WIP pull request to the openjdk/jfx repo if you want to continue working on it. Here are instructions for migrating your pull request. The updated CONTRIBUTING.md doc has additional information on how to proceed.

Once you have done this, it would be helpful to add a comment with a pointer to the new PR.


The new openjdk/jfx repo will be open for pull requests on Wednesday, 2-Oct-2019. I will send email to the openjfx-dev mailing list announcing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Experiment Experimental changes, not intented for merge WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants