Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction: alert, prompt, confirm #173

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andreimuntean1
Copy link

No description provided.

@javascript-translate-bot

Error: the article already has PR number in the Progress Issue #1, it's 170 ⁉️

Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Textul trebuie re-formatat.

@@ -15,6 +15,7 @@
.cache
.project
.settings
.vscode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.vscode

Nu trebuie să adăugăm setări care nu erau acolo

</script>

</body>
let name = prompt("Cum te numești?", "");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presupun că ai o setare în VSCode care formatează textul.
Traducerea trebuie să aibă același format cu cel original. Dezactivează extensiile precum Prettier.

alert(`You are ${age} years old!`); // You are 100 years old!
```
alert(`Ai ${age} de ani!`); // Ai 100 de ani!
````
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atenție la formatare


```js run
let test = prompt("Test", ''); // <-- for IE
let test = prompt("Test", ""); // <-- pentru Internet Explorer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let test = prompt("Test", ""); // <-- pentru Internet Explorer
let test = prompt("Test", ''); // <-- pentru Internet Explorer

formatare

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants