render version string countability more imperturbable #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-number characters are replaced in version number partitions. Empty version number partitions are replaced with 0. In case the resulting version string is invalid a checked exception is thrown. This exception is catched in UtilsLibrary.java.
dhebbeker
commented
May 22, 2018
| { | ||
| String trimmedVersion = version.replaceAll("[^0-9?!\\.]", ""); | ||
| // replace all empty version number-parts with zeros | ||
| trimmedVersion = trimmedVersion.replaceAll("\\.(\\.|$)", "\\.0$1"); |
There was a problem hiding this comment.
This is the crucial change for #136
|
Thank you 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preamble
A version string shall be composed of version partitions which are concatenated by dots. A version partition can be for example the major version number.
Current situation
Non-number characters are removed in version number partitions.
Change
Empty version number partitions are replaced with 0. In case the resulting version string is invalid a checked exception is thrown. This exception is catched in UtilsLibrary.java.
Effect
A version string is transformed from
2.1.3.alpha.42.RCto2.1.3..42.to2.1.3.0.42.0. Without this change an integer conversion error occurs when attempting to convert the empty version partitions.