Skip to content

Commit

Permalink
Fix javadoc breaking change: destDir removed
Browse files Browse the repository at this point in the history
  • Loading branch information
javiertuya committed Sep 9, 2024
1 parent 7c38b52 commit 1ac4ca7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Upload artifact
uses: actions/upload-pages-artifact@v3
with:
path: 'target/site/testapidocs'
path: 'target/reports/testapidocs'
- name: Deploy to GitHub Pages
id: deployment
uses: actions/[email protected]
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Preparación del repositorio y del eproyecto:
## Reports

La instalacion anterior compilará, ejecutará pruebas y dispondrá de los reports en carpetas dentro de `target`:
- `site/testapidocs/index.html`: javadoc del proyecto
- `reports/testapidocs/index.html`: javadoc del proyecto
- `site/surefire-report.html`: report de las pruebas unitarias (ut)
- `site/junit*`: report de todas las pruebas con el formato que genera junit
- `site/jacoco-ut`: reports de cobertura de código
Expand Down
5 changes: 2 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@
<configuration>
<overview>${basedir}/src/main/java/overview.html</overview>
<sourcepath>${basedir}/src/main/java;${basedir}/src/test/java;${basedir}/src/it/java</sourcepath>
<destDir>apidocs</destDir>
<!-- Desde v3.10, destDir ha sido eliminada, la doc indica que ahora es reportOutputDirectory
Pero esto tampoco funciona con v3.10, uso directorio por defecto: target/reports/testapidocs -->
<quiet>true</quiet>
<doclint>none</doclint>
</configuration>
Expand All @@ -220,8 +221,6 @@
<id>generate-all-javadocs</id>
<phase>install</phase>
<goals>
<!--normalmente este goal seria jar, no interesa el jar, solo el javadoc
y evita warnings/errores porque se estan generando javadocs de los tests-->
<goal>test-javadoc</goal>
</goals>
</execution>
Expand Down

0 comments on commit 1ac4ca7

Please sign in to comment.