forked from urllib3/urllib3
-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
❇️ Discrete idle connection watcher scheduler #162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the fix shipped in v2.10.906 and avoid having to recycle your multiplexed connection in idle moments. A new keyword argument is supported in your PoolManager configuration, namely ``background_watch_delay``. This parameter takes a int or float as the delay between checks. Set it to None to void this background task.
Ousret
force-pushed
the
feat-eagle-watch
branch
from
October 18, 2024 07:50
dd7decc
to
b1e7b4e
Compare
…_delay for BC sake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.11.900 (2024-10-21)
ConnectionPool
to watch for unsolicited incoming data.This improves the fix shipped in v2.10.906 and avoid having to recycle your multiplexed connection in idle moments.
A new keyword argument is supported in your PoolManager configuration, namely
background_watch_delay
.This parameter takes a int or float as the delay between checks. Set it to None to void this background task.
Anything lower than
0.01
will be interpreted as None, therefor disabling the discrete watch.keepalive_delay
thattakes a value expressed in seconds for how long urllib3-future should automatically keep the connection alive.
This is done in direct extension to our "discrete task" mentioned just before. We will send
PING
frameautomatically to the remote peer every 60s by default (after idle for 60s to be clear). The window delay for
sending a
PING
is configurable via thekeepalive_idle_window
parameter. Learn more about this in ourdocumentation.