lib: rest_client: Fix memory leak during timeout

This issue was pointed out by Coverity. Signed-off-by: Tommi Rantanen <[email protected]>
jayteemo · Sep 5, 2023 · 9a9e46b · 9a9e46b
1 parent d2e56b7
commit 9a9e46b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/subsys/net/lib/rest_client/src/rest_client.c b/subsys/net/lib/rest_client/src/rest_client.c
@@ -197,7 +197,8 @@ static int rest_client_sckt_connect(int *const fd,
 		/* Check if timeout has already elapsed */
 		if (time_used >= *timeout_ms) {
 			LOG_WRN("Timeout occurred during DNS query");
-			return -ETIMEDOUT;
+			ret = -ETIMEDOUT;
+			goto clean_up;
 		}
 	}
 
@@ -244,7 +245,8 @@ static int rest_client_sckt_connect(int *const fd,
 		/* Check if timeout has already elapsed */
 		if (time_used >= *timeout_ms) {
 			LOG_WRN("Timeout occurred during socket connect");
-			return -ETIMEDOUT;
+			ret = -ETIMEDOUT;
+			goto clean_up;
 		}
 		*timeout_ms -= time_used;
 	}