Iris 5723 nrf jwt #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Morton <[email protected]>
Signed-off-by: Justin Morton <[email protected]>
Signed-off-by: Justin Morton <[email protected]>
| /* Find and remove end string */ | ||
| end = strstr(str, END_PRV_KEY); | ||
| if (end == NULL) { | ||
| return -EINVAL; |
There was a problem hiding this comment.
This will fail for non-PEM credentials, which we may or may not want to have at our disposal. It saves RAM, at least
| } | ||
| memcpy(pem, private_key, pem_sz); | ||
| #else | ||
| /* Get the private key from protected storage */ |
There was a problem hiding this comment.
Worth noting: Whether it comes from protected storage depends on the backend being used with the TLS credentials module
Comment on lines
+158
to
+176
| #if defined(CONFIG_NRF_CLOUD_COAP_WIFI_ADD_CREDS_FROM_FILE) | ||
| err = tls_credential_add(CONFIG_NRF_CLOUD_SEC_TAG, | ||
| TLS_CREDENTIAL_CA_CERTIFICATE, | ||
| ca_certificate, | ||
| sizeof(ca_certificate)); | ||
| if (err < 0) { | ||
| LOG_ERR("Failed to add CA certificate: %d", err); | ||
|
|
||
| } | ||
|
|
||
| err = tls_credential_add(CONFIG_NRF_CLOUD_SEC_TAG, | ||
| TLS_CREDENTIAL_PRIVATE_KEY, | ||
| private_key, | ||
| sizeof(private_key)); | ||
| if (err < 0) { | ||
| LOG_ERR("Failed to add private key: %d", err); | ||
| } | ||
|
|
||
| #endif |
There was a problem hiding this comment.
Hmm, we already have CONFIG_NRF_CLOUD_PROVISION_CERTIFICATES which does nearly the same thing
It would be nice if we could just alter/extend that to work for CoAP
Or at least re-use the KConfig Symbol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.