Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use coap_client + download_client for nrf cloud coap downloads #9

Closed
wants to merge 3 commits into from

Conversation

jayteemo
Copy link
Owner

@jayteemo jayteemo commented May 2, 2024

No description provided.

WIP - functional demo

Signed-off-by: Justin Morton <[email protected]>

struct coap_client_request request = {
.method = COAP_METHOD_GET,
.confirmable = true, // todo ?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a bad idea to allow folks to do FOTA especially with non-confirmable transfers.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reason to expose an option to the user? this would not always be used for FOTA downloads.

Copy link
Collaborator

@plskeggs plskeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

@jayteemo jayteemo force-pushed the IRIS-8806_with_dlc branch from 9933ce9 to f2ff64d Compare May 13, 2024 17:51
jayteemo added 2 commits May 13, 2024 10:57
Expose transport functions so that external coap_client
instances can be used with nRF Cloud.
IRIS-8806

Signed-off-by: Justin Morton <[email protected]>
@jayteemo jayteemo force-pushed the IRIS-8806_with_dlc branch from f2ff64d to f8e0fb3 Compare May 13, 2024 17:57
@jayteemo jayteemo closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants