utf8view fix

jayzhan211 · Feb 11, 2025 · cac8400 · cac8400
1 parent d5428b2
commit cac8400
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/datafusion/expr-common/src/type_coercion/binary.rs b/datafusion/expr-common/src/type_coercion/binary.rs
@@ -537,8 +537,16 @@ fn type_union_resolution_coercion(
         }
         (DataType::Dictionary(index_type, value_type), other_type)
         | (other_type, DataType::Dictionary(index_type, value_type)) => {
-            let new_value_type = type_union_resolution_coercion(value_type, other_type);
-            new_value_type.map(|t| DataType::Dictionary(index_type.clone(), Box::new(t)))
+            match type_union_resolution_coercion(value_type, other_type) {
+                // Dict(k, Utf8View) is redundant, Utf8View is good enough
+                Some(DataType::Utf8View) => {
+                    Some(DataType::Utf8View)
+                }
+                Some(new_value_type) => {
+                    Some(DataType::Dictionary(index_type.clone(), Box::new(new_value_type)))
+                }
+                None => None,
+            }
         }
         (DataType::Struct(lhs), DataType::Struct(rhs)) => {
             if lhs.len() != rhs.len() {