Extra Functions #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functions for zooming in automatically (graph fits within the bounds of the brain screen no matter what), for inserting a premade graph, and for getting a reference to the container.
jazonshou
requested changes
Jan 31, 2024
| @@ -47,7 +48,7 @@ class AsyncGrapher : public TaskWrapper { | |||
| * @param name data type name | |||
| * @param val updated data value | |||
| */ | |||
| void update(const std::string &name, double val); | |||
| void update(const std::string &name, double val, double maxValArg = 1); | |||
There was a problem hiding this comment.
Please update the comment block to include documentation for maxValArg
Add comment for update() func
jazonshou
approved these changes
Oct 16, 2024
| @@ -47,7 +48,7 @@ class AsyncGrapher : public TaskWrapper { | |||
| * @param name data type name | |||
| * @param val updated data value | |||
| */ | |||
| void update(const std::string &name, double val); | |||
| void update(const std::string &name, double val, double maxValArg = 1); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions for zooming in automatically (graph fits within the bounds of the brain screen no matter what), for inserting a premade graph, and for getting a reference to the container.