Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add translations #179

wants to merge 1 commit into from

Conversation

nortigo
Copy link

@nortigo nortigo commented Mar 21, 2021

Please let me know if there is something wrong. I'll fix it.

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #179 (b4b9668) into master (743b538) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   90.98%   91.00%   +0.02%     
==========================================
  Files          12       12              
  Lines         377      378       +1     
==========================================
+ Hits          343      344       +1     
  Misses         34       34              
Impacted Files Coverage Δ
defender/utils.py 98.52% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 743b538...b4b9668. Read the comment docs.

Copy link
Collaborator

@kencochrane kencochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not very familiar with translations, so it might be good to get another review before we merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants