Make auth header prefix configurable #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm very much in favor of this. |
|
@qpfmtlcp thank you for your contribution. I'm happy to add this. Please add test coverage, as in a unit test that confirms one can successfully login with the right prefix and not with the wrong prefix. |
johnraz
approved these changes
Oct 10, 2018
| @@ -44,6 +44,9 @@ def get_basic_auth_header(username, password): | |||
| user_serializer_knox = knox_settings.defaults.copy() | |||
| user_serializer_knox["USER_SERIALIZER"] = UserSerializer | |||
|
|
|||
| auth_header_prefix_knox = knox_settings.defaults.copy() | |||
| auth_header_prefix_knox["AUTH_HEADER_PREFIX"] = 'Baerer' | |||
There was a problem hiding this comment.
For the sake of correctness this should be 'Bearer' 😉
There was a problem hiding this comment.
oops. I really appreciate your review.
|
nice work 👍 |
dontexit
pushed a commit
to dontexit/django-rest-knox
that referenced
this pull request
Jan 24, 2024
Make auth header prefix configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #19