Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bugs #156

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Fix some bugs #156

merged 3 commits into from
Nov 27, 2023

Conversation

chengsecret
Copy link
Contributor

  1. Resolve dependency conflicts of slf4j-api .
  2. Fix bug of SiftSmall : IO Stream not closed caused an error: An exception will be reported when executing 'Files. delete (testDirectory)'.

@jbellis jbellis self-requested a review November 22, 2023 15:53
@jbellis
Copy link
Owner

jbellis commented Nov 22, 2023

Thank you! Could you sign the CLA at https://cla.datastax.com/ ?

@chengsecret
Copy link
Contributor Author

Thank you! Could you sign the CLA at https://cla.datastax.com/ ?

sure😄

@chengsecret
Copy link
Contributor Author

Thank you! Could you sign the CLA at https://cla.datastax.com/ ?

finished. Thanks for your reply.

@jbellis jbellis requested review from jkni and removed request for jbellis November 22, 2023 17:56
@jkni jkni merged commit 521d482 into jbellis:main Nov 27, 2023
4 checks passed
@jkni
Copy link
Collaborator

jkni commented Nov 27, 2023

Thank you! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkni jkni jkni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chengsecret @jbellis @jkni