-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hero.describe(s), Closes #166 #168
Open
henrifroese
wants to merge
26
commits into
jbesomi:master
Choose a base branch
from
SummerOfCode-NoHate:hero_describe_function
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement hero.describe(s), Closes #166 #168
henrifroese
wants to merge
26
commits into
jbesomi:master
from
SummerOfCode-NoHate:hero_describe_function
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suport MultiIndex as function parameter returns MultiIndex, where Representation was returned * missing: correct test Co-authored-by: Henri Froese <[email protected]>
*missing: test adopting for new types Co-authored-by: Henri Froese <[email protected]>
- add functionality for decorator @InputSeries to handle several allowed input types - Add typing decorator/hints to representation.py - add tests for _types DocumentTermDF Co-authored-by: Maximilian Krahn <[email protected]>
Co-authored-by: Maximilian Krahm <[email protected]>
…describe_function"
Co-authored-by: Henri Froese <[email protected]>
17 tasks
this branch is now based on the master and ready for review/to be merged 🦸 🦸♂️ 🦸♀️ |
Amazing, will check soon and let you know! 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward implementation of description in #166 .
Example:
Screenshot of pretty-printed output from Google Colab:
Note: only so many lines changed because this builds upon #157