Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NLP Tutorial #176

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

henrifroese
Copy link
Collaborator

@henrifroese henrifroese commented Sep 6, 2020

This builds upon

TODO

  • add references at the end to the other tutorials

EDIT:

You can now see the tutorial with the images right here. Will switch images to higher res. as some are a little blurry. Apart from that, I'm interested in opinions content- and style-wise 🤞

@henrifroese henrifroese added the documentation Improvements or additions to documentation label Sep 6, 2020
@henrifroese henrifroese marked this pull request as draft September 6, 2020 11:24
@henrifroese henrifroese requested a review from mk2510 September 6, 2020 11:24
@jbesomi
Copy link
Owner

jbesomi commented Sep 8, 2020

Looks good! 👍

Review:

  • For the DF output, it would be elegant if you just copy-paste the output as we are doing in the getting-started (See "Getting Started" section, for instance, >>> df.head(2) )
  • This will need to go under website/blog as this is a Tutorial blog post and not a "getting started" page
  • Try to have subsection shorter and eventually add a sub-sub section.
  • "Of course, we use Texthero's count_sentences function.". Is "Of course" pertinent?

Extra:

  • We will need to adapt a bit the CSS code for the code snippet, it does not look that good (but that's not related with this PR)

Example:

Count Sentences - Who is the most well-known superhero?

Becomes

Count Sentences

Who is the most well-known superhero?

website/docs/tutorial-nlp.md Outdated Show resolved Hide resolved
website/docs/tutorial-nlp.md Outdated Show resolved Hide resolved
website/docs/tutorial-nlp.md Outdated Show resolved Hide resolved
@henrifroese
Copy link
Collaborator Author

Incorporated the suggested changes from both your reviews 🪂 .

This will need to go under website/blog as this is a Tutorial blog post and not a "getting started" page

I believe that this should be getting-started-nlp (We accidentally named it tutorial-nlp) as this showcases the nlp module and tutorials should probably be more focused and in-depth (e.g. "Sparsity" or "Topic Modelling")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants