Propertly implement blocktypes #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few "special" blocktypes, the void type and the single value result types. These don't correspond to an indexed type, instead the emitter and runtime just handles them directly. This also changes to emitting the function arity rather than the index, since that's what's needed at runtime, and it makes it easier to handle these special non-index types. Also remove the "void" value, which doesn't really exist in WASM, and was just a bad workaround for trying to populate an error parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few "special" blocktypes, the void type and the single value
result types. These don't correspond to an indexed type, instead the emitter
and runtime just handles them directly.
This also changes to emitting the function arity rather than the index, since
that's what's needed at runtime, and it makes it easier to handle these
special non-index types.
Also remove the "void" value, which doesn't really exist in WASM, and was just
a bad workaround for trying to populate an error parameter.