Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMW-239 Reorganize tabs in Jenkins by product rather project type #255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RanabirChakraborty
Copy link
Contributor

roles/jenkins/templates/casc.yaml.j2 Outdated Show resolved Hide resolved
@RanabirChakraborty RanabirChakraborty force-pushed the AMW-239 branch 5 times, most recently from b3b0167 to 9007b7f Compare January 10, 2025 16:39
@rpelisse
Copy link
Collaborator

@RanabirChakraborty I've checkout your change and ran the added molecule test. It does work, however, int the generated casc.yml file I cannot see the tabs/view:

# cat /tmp/casc_generated.yaml 
configuration-as-code:
  deprecated: warn
jenkins:
  globalNodeProperties:
    - envVars:
        env:
          - key: "JENKINS_HOME_DIR"
            value: "/home/jenkins/current/"
  numExecutors: 12
  securityRealm:
    local:
      allowsSignup: false
      users:
       - id: admin
         password: admin_password

security:
  globalJobDslSecurityConfiguration:
    useScriptSecurity: false
tool:

unclassified:
  location:
    url: http://example.jenkins.server
  email-ext:
    defaultRecipients: "[email protected]"
    defaultSuffix: "@redhat.com"
    mailAccount:
      smtpHost: "smtp.example.com"
  mailer:
    replyToAddress: [email protected]
    smtpHost: smtp.example.com
    smtpPort: 587
jobs:
  - url: "https://raw.githubusercontent.com/jboss-set/cedalion/main/job-configurator.groovy"
  - script: "queue('job-configurator')"

@RanabirChakraborty RanabirChakraborty force-pushed the AMW-239 branch 2 times, most recently from 5419685 to 5f3eae9 Compare January 20, 2025 16:10
@rpelisse
Copy link
Collaborator

@RanabirChakraborty looks better, but locally, I had to fix the indentation of the instance variable, maybe you should double check that, that could explain the failing CI.

@RanabirChakraborty RanabirChakraborty force-pushed the AMW-239 branch 3 times, most recently from e0e6ee7 to c4aff2a Compare January 20, 2025 20:35
@RanabirChakraborty
Copy link
Contributor Author

@rpelisse thanks for the review! I guess it looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants