Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: room modifiers #10

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: room modifiers #10

wants to merge 4 commits into from

Conversation

jbreneman
Copy link
Owner

Adds room modifiers as a concept to the app. Modifiers are added via the edit room panel, and show as icons on the room itself. On purchased rooms, you can set a single set of modifiers. On unpurchased rooms, users can set modifiers for each cardinal direction, to plan for the future. When connecting an unpurchased to a purchased room, the first connection made will be set as the room modifiers.

@jbreneman jbreneman self-assigned this Feb 1, 2024
Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for shiny-nougat-b53846 ready!

Name Link
🔨 Latest commit 0281223
🔍 Latest deploy log https://app.netlify.com/sites/shiny-nougat-b53846/deploys/65c11736237aaf00080e28a5
😎 Deploy Preview https://deploy-preview-10--shiny-nougat-b53846.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@radimous
Copy link

radimous commented Feb 2, 2024

the modifier icons look blurred now
to fix this use the original 16x16 icons with image-rendering: pixelated css

@jbreneman
Copy link
Owner Author

the modifier icons look blurred now to fix this use the original 16x16 icons with image-rendering: pixelated css

Hey thanks, have not run into this before. Looks a lot better.

@radimous
Copy link

radimous commented Feb 5, 2024

np but you are still using weirdly upscaled images instead of the original 16x16 icons
pixelated rendering will use nearest neighbor upscaling, so it would look literally perfect (same as in game)
here is how it looks like when you change the opulent icon from 32x32 to 16x16:
modifiers
also they've changed some icons in the latest update, so it would be great to update them here too

@jbreneman
Copy link
Owner Author

np but you are still using weirdly upscaled images instead of the original 16x16 icons

Yeah I had a hard time finding the proper icons for this, is there somewhere you can point me to get the originals or are you saying just downscale my current ones from 32x32 to 16x16?

@radimous
Copy link

radimous commented Feb 6, 2024

I've got them directly from the jar (path: assets/the_vault/textures/gui/modifiers)
here all all modifier icons that can appear in paradox vault in the current update (Update 13)
paradox_modifiers.zip

here is icon name -> label map

crowded -> "Wild"
extended -> "Extended"
furious_mobs -> "Angry Mobs"
gilded -> "Gilded"
champion_increase -> "More Champions"
chunky -> "Chunky Mobs"
item_quant_2 -> "Opulent"
item_rarity_2 -> "Lucky"
living -> "Living"
ornate -> "Ornate"
phoenix -> "Phoenix"
plentiful -> "Plentiful"
rapid_mobs -> "Rapid Mobs"
shortened -> "Shortened"
soul_shard_increase_pink -> "Soul Harvest"
trapped -> "Clumsy"
wealthy -> "Wealthy"
wooden -> "Wooden"

as you can see few things have changed
trapped was renamed to clumsy, furious was renamed to angry mobs and icon was changed and lucky icon was also changed

@radimous
Copy link

radimous commented Feb 6, 2024

I've just noticed that you can mark portal room as not purchased and and if you don't have any other room you can't even "purchase" it back

2024-02-06.12-24-53.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rooms that are connected and then unconnected do not get marked as unpurchased again Add room modifiers
2 participants