Skip to content

Commit

Permalink
pump version 0.8.8
Browse files Browse the repository at this point in the history
  • Loading branch information
jbytecode committed Dec 18, 2021
1 parent 3861af2 commit 75c1aab
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fail-fast: false
matrix:
version:
- 1.6.4
- 1.7
os:
- ubuntu-latest
- macOS-latest
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "LinRegOutliers"
uuid = "6d4de0fb-32d9-4c65-aac1-cc9ed8b94b1a"
authors = ["Mehmet Hakan Satman <[email protected]>", "Shreesh Adiga <[email protected]>", "Guillermo Angeris <[email protected]>", "Emre Akadal <[email protected]>"]
version = "0.8.7"
version = "0.8.8"

[deps]
Clustering = "aaaa29a8-35af-508c-8bc3-b662a17a0fe5"
Expand Down
7 changes: 4 additions & 3 deletions src/ols.jl
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ julia> reg.betas
See also: [`OLS`](@ref), [`wls`](@ref)
"""
ols(X::Array{Float64,2}, y::Array{Float64,1})::OLS = OLS(X, y, qr(X, Val(true)) \ y)

#ols(X::Array{Float64,2}, y::Array{Float64,1})::OLS = OLS(X, y, qr(X, Val(true)) \ y)
ols(X::Array{Float64,2}, y::Array{Float64,1})::OLS = OLS(X, y, qr(X, ColumnNorm()) \ y)


"""
Expand Down Expand Up @@ -80,7 +80,8 @@ function wls(X::Array{Float64,2}, y::Array{Float64,1}, wts::Array{Float64,1})::O
#  I commented this because passing weighted values of X and y to OLS
#  causes wrong calculations of residuals.
# return ols(W * X, W * y)
return OLS(X, y, qr(W * X, Val(true)) \ (W * y))
# return OLS(X, y, qr(W * X, Val(true)) \ (W * y))
return OLS(X, y, qr(W * X, ColumnNorm()) \ (W * y))
end


Expand Down

0 comments on commit 75c1aab

Please sign in to comment.