Refactor websocker.go & websocket_server.go to merge both goroutines #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcelliott
added a commit
that referenced
this pull request
Sep 2, 2015
Refactor websocker.go & websocket_server.go to merge both goroutines
|
Thanks, this is definitely an improvement. Looks like there are still some issues (pre-existing) with the code around closing the websocket connection. I've opened another issue for that (#94). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the goroutines in
websocket.goandwebsocket_server.gowere diverging. More specifically, the loop inwebsocket.gowas not closingep.messages