test: add test cases for no-op fillna expressions

jcrist · May 7, 2024 · c2e67a4 · c2e67a4
1 parent 378251e
commit c2e67a4
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/ibis/backends/tests/test_generic.py b/ibis/backends/tests/test_generic.py
@@ -464,6 +464,7 @@ def test_table_fillna_invalid(alltypes):
         param({"int_col": 20}, id="int"),
         param({"double_col": -1, "string_col": "missing"}, id="double-int-str"),
         param({"double_col": -1.5, "string_col": "missing"}, id="double-str"),
+        param({}, id="empty"),
     ],
 )
 def test_table_fillna_mapping(backend, alltypes, replacements):
@@ -497,6 +498,17 @@ def test_table_fillna_scalar(backend, alltypes):
     backend.assert_frame_equal(res, sol, check_dtype=False)
 
 
+def test_table_fillna_scalar_no_nullable_columns(backend, alltypes):
+    table = alltypes.select("int_col", "double_col").cast(
+        {"int_col": "!int64", "double_col": "!float64"}
+    )
+    pd_table = table.execute()
+
+    res = table.fillna(0).execute().reset_index(drop=True)
+    sol = pd_table.fillna(0).reset_index(drop=True)
+    backend.assert_frame_equal(res, sol, check_dtype=False)
+
+
 def test_mutate_rename(alltypes):
     table = alltypes.select(["bool_col", "string_col"])
     table = table.mutate(dupe_col=table["bool_col"])