fix(oracle): support connection using oracle connection string (ibis-…

…project#9435)
jcrist · Jun 24, 2024 · f3cd8b2 · f3cd8b2
1 parent 2c9198d
commit f3cd8b2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/ibis/backends/oracle/__init__.py b/ibis/backends/oracle/__init__.py
@@ -9,6 +9,7 @@
 from functools import cached_property
 from operator import itemgetter
 from typing import TYPE_CHECKING, Any
+from urllib.parse import urlparse
 
 import numpy as np
 import oracledb
@@ -160,7 +161,14 @@ def do_connect(
         oracledb.defaults.fetch_decimals = True
 
     def _from_url(self, url: str, **kwargs):
-        return self.do_connect(user=url.username, password=url.password, dsn=url.host)
+        url = urlparse(url)
+        self.do_connect(
+            user=url.username,
+            password=url.password,
+            database=url.path.removeprefix("/"),
+        )
+
+        return self
 
     @property
     def current_database(self) -> str:

diff --git a/ibis/backends/oracle/tests/test_client.py b/ibis/backends/oracle/tests/test_client.py
@@ -71,3 +71,9 @@ def test_list_tables_schema_warning_refactor(con):
         assert con.list_tables(schema="SYS", like="EXU8OPT") == ["EXU8OPT"]
 
     assert con.list_tables(database="SYS", like="EXU8OPT") == ["EXU8OPT"]
+
+
+def test_from_url(con):
+    new_con = ibis.connect("oracle://ibis:ibis@localhost:1521/IBIS_TESTING")
+
+    assert new_con.list_tables()