Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some configuration options to allow either the Analog reading of the FSR, or digital reading #7

Open
wants to merge 8 commits into
base: fsr
Choose a base branch
from

Conversation

tmolteno
Copy link

@tmolteno tmolteno commented Jul 5, 2014

Hi There

I have made a couple of changes.

  1. Configuration.h has had a few defines added to allow either FSR-analog or FSR-digital.
  2. qr_solve has had an include changed to allow compilation
  3. Marlin_main has had the code cleaned up around reading the state of the bed touching in the auto-callibration.

Kind Regards

Tim Molteno

@cdaringe
Copy link

cdaringe commented Jul 6, 2014

It looks like some of your personal config made it into this pull req. It may be worth saving the diff, re-checking out, and commiting only your features/updates

@tmolteno
Copy link
Author

tmolteno commented Jul 6, 2014

Good point. Apologies for that. The problem is that the commits will then be untested (as I can't run them on my machine).

How about I refactor the configuration.h into several configuration files. One for machine geometry, another for bed leveling e.t.c

configuration.h, (most of the usual stuff)
config_geometry.h (dimensions entered during calibration)
config_autocal.h (fsr configurations e.t.c)

This will make it easier to work from a git repository.

P.S. Should the xyz pulley size default (XYZ_PULLEY_TEETH) really be 17 teeth? Mine have 16.

Cheers
Tim

tmolteno added 3 commits July 9, 2014 22:00
… typical delta printer. This makes hunting for the configuration options, and setting them a little easier for the novice user. It also makes it easier to develop Marlin firmware without spamming the main configuration.h with local changes.
…to allow the most common calibrations to be stored in Calibration.h.
@tmolteno
Copy link
Author

tmolteno commented Jul 9, 2014

Hi There

I have make the changes I suggested in the last comment.

  1. Tried to put all the sensible local overrides into a file called Calibration.h.
  2. Added a comment to note that the existing defaults are suitable for a Kossel Air (rather than a Mini)
  3. Added a new SCALING_FACTOR option that is modified when printing test cubes to calibrate dimensions.
  4. Added an EXTRUDER_STEPS option that is modified when calibrating the extruder.

Now the pull request includes, both those changes, and the cleanup of the FSR code to allow either ZMIN or TEMP inputs to be used for auto bed leveling, as described in by earlier comments.

Happy to receive suggestions for improvements.

Kind Regards

Tim

tmolteno and others added 2 commits July 10, 2014 08:26
…r input to read the force sensitive resistors for the level sensing and auto callibration
ex-nerd pushed a commit to OpenBeamUSA/Marlin that referenced this pull request Nov 10, 2015
Provide both long and short version strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants