Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and do cleanup #162

Merged
merged 8 commits into from
Nov 12, 2023
Merged

Fix CI and do cleanup #162

merged 8 commits into from
Nov 12, 2023

Conversation

tobias-urdin
Copy link
Collaborator

This gets the CI working again on Ubuntu 22.04 (Jammy) with Python 3.10, we are not testing with Python 3.9 right now because we need the Ceph jobs to be skipped for that because the python3-rados package is required for that.

This reverts commit 867f7ae that was wrong but not caught due to no CI.

This moves away from PBR to just using setuptools and adds a job to verify building, also removes the support for Python 3.6 and 3.7 in setup.cfg which means the minimum supported version will be Python 3.8 even though that is not tested as of now.

This gets the CI working with Ubuntu 22.04
(Jammy) inside a docker container that runs
on ubuntu-latest.
@tobias-urdin tobias-urdin mentioned this pull request Nov 9, 2023
@tobias-urdin tobias-urdin requested a review from jd November 9, 2023 14:43
@felixonmars felixonmars merged commit eb428f1 into jd:master Nov 12, 2023
2 checks passed
@felixonmars
Copy link
Collaborator

It seems that the CI fails after merging. Any ideas?

image

@tobias-urdin
Copy link
Collaborator Author

I think that's because github actions needs write permissions for packages to upload the CI docker image, should be somewhere in the settings

@tobias-urdin
Copy link
Collaborator Author

tobias-urdin commented Jan 25, 2024

@jd can you go to Settings -> Actions in sidebar menu -> under Workflow permissions section and verify "Read and write permissions" is checked

@jd
Copy link
Owner

jd commented Jan 29, 2024

CleanShot 2024-01-29 at 12 22 47@2x
It is, I did not change anything.

@tobias-urdin
Copy link
Collaborator Author

tobias-urdin commented Jan 29, 2024

CleanShot 2024-01-29 at 12 22 47@2x It is, I did not change anything.

not sure what permission is needed, but the push from the CI job to packages is failing, it does the same things as gnocchi does for the container image
https://github.com/jd/pifpaf/actions/runs/7696530204/job/20971565237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants