refactor: started the work to merge tool and plugin struct/traits

src/config/mod.rs

@@ -283,9 +283,14 @@ fn load_tools(settings: &Settings) -> Result<ToolMap> {
     if settings.experimental {
         tools.extend(EXPERIMENTAL_CORE_PLUGINS.clone());
     }
-    let plugins = Tool::list()?
+    let plugins = ExternalPlugin::list()?
         .into_par_iter()
-        .map(|p| (p.name.clone(), Arc::new(p)))
+        .map(|p| {
+            (
+                p.name.clone(),
+                Arc::new(Tool::new(p.name.clone(), Box::new(p))),
+            )
+        })
         .collect::<Vec<_>>();
     tools.extend(plugins);
     for tool in &settings.disable_tools {

src/plugins/core/bun.rs

@@ -107,7 +107,7 @@ impl Plugin for BunPlugin {
         Ok(vec![".bun-version".into()])
     }
 
-    fn install_version(&self, ctx: &InstallContext) -> Result<()> {
+    fn install_version_impl(&self, ctx: &InstallContext) -> Result<()> {
         assert!(matches!(
             &ctx.tv.request,
             ToolVersionRequest::Version { .. }

src/plugins/core/deno.rs

@@ -105,7 +105,7 @@ impl Plugin for DenoPlugin {
         Ok(vec![".deno-version".into()])
     }
 
-    fn install_version(&self, ctx: &InstallContext) -> Result<()> {
+    fn install_version_impl(&self, ctx: &InstallContext) -> Result<()> {
         assert!(matches!(
             &ctx.tv.request,
             ToolVersionRequest::Version { .. }

src/plugins/core/go.rs

@@ -149,15 +149,15 @@ impl Plugin for GoPlugin {
         Ok(vec![".go-version".into()])
     }
 
-    fn install_version(&self, ctx: &InstallContext) -> Result<()> {
+    fn install_version_impl(&self, ctx: &InstallContext) -> Result<()> {
         let tarball_path = self.download(&ctx.tv, &ctx.pr)?;
         self.install(&ctx.tv, &ctx.pr, &tarball_path)?;
         self.verify(ctx.config, &ctx.tv, &ctx.pr)?;
 
         Ok(())
     }
 
-    fn uninstall_version(&self, _config: &Config, tv: &ToolVersion) -> Result<()> {
+    fn uninstall_version_impl(&self, _config: &Config, tv: &ToolVersion) -> Result<()> {
         let gopath = self.gopath(tv);
         if gopath.exists() {
             cmd!("chmod", "-R", "u+wx", gopath).run()?;

src/plugins/core/java.rs

@@ -262,7 +262,7 @@ impl Plugin for JavaPlugin {
         Ok(aliases)
     }
 
-    fn install_version(&self, ctx: &InstallContext) -> Result<()> {
+    fn install_version_impl(&self, ctx: &InstallContext) -> Result<()> {
         assert!(matches!(
             &ctx.tv.request,
             ToolVersionRequest::Version { .. }

src/plugins/core/node.rs

@@ -260,7 +260,7 @@ impl Plugin for NodePlugin {
         Ok(body.to_string())
     }
 
-    fn install_version(&self, ctx: &InstallContext) -> Result<()> {
+    fn install_version_impl(&self, ctx: &InstallContext) -> Result<()> {
         let opts = BuildOpts::new(ctx)?;
         debug!("node build opts: {:#?}", opts);
         if *env::RTX_NODE_COMPILE {

src/plugins/core/node_build.rs

@@ -252,7 +252,7 @@ impl Plugin for NodeBuildPlugin {
         exit(0);
     }
 
-    fn install_version(&self, ctx: &InstallContext) -> Result<()> {
+    fn install_version_impl(&self, ctx: &InstallContext) -> Result<()> {
         self.install_node_build()?;
         ctx.pr.set_message("running node-build");
         let mut cmd = CmdLineRunner::new(&ctx.config.settings, self.node_build_bin())

src/plugins/core/python.rs

@@ -169,7 +169,7 @@ impl Plugin for PythonPlugin {
         Ok(vec![".python-version".to_string()])
     }
 
-    fn install_version(&self, ctx: &InstallContext) -> Result<()> {
+    fn install_version_impl(&self, ctx: &InstallContext) -> Result<()> {
         self.install_python_build()?;
         if matches!(&ctx.tv.request, ToolVersionRequest::Ref(..)) {
             return Err(eyre!("Ref versions not supported for python"));

src/plugins/core/ruby.rs

@@ -346,7 +346,7 @@ impl Plugin for RubyPlugin {
         Ok(v)
     }
 
-    fn install_version(&self, ctx: &InstallContext) -> Result<()> {
+    fn install_version_impl(&self, ctx: &InstallContext) -> Result<()> {
         self.update_build_tool()?;
         assert!(matches!(
             &ctx.tv.request,

src/plugins/external_plugin.rs

@@ -81,6 +81,13 @@ impl ExternalPlugin {
         }
     }
 
+    pub fn list() -> Result<Vec<Self>> {
+        Ok(file::dir_subdirs(&dirs::PLUGINS)?
+            .into_iter()
+            .map(Self::new)
+            .collect())
+    }
+
     fn get_repo_url(&self, config: &Config) -> Result<String> {
         self.repo_url
             .clone()
@@ -388,7 +395,7 @@ impl Plugin for ExternalPlugin {
 
     fn latest_stable_version(&self, settings: &Settings) -> Result<Option<String>> {
         if !self.has_latest_stable_script() {
-            return Ok(None);
+            return self.latest_version(settings, Some("latest".into()));
         }
         self.latest_stable_cache
             .get_or_try_init(|| self.fetch_latest_stable(settings))
@@ -617,7 +624,7 @@ impl Plugin for ExternalPlugin {
         exit(result.status.code().unwrap_or(1));
     }
 
-    fn install_version(&self, ctx: &InstallContext) -> Result<()> {
+    fn install_version_impl(&self, ctx: &InstallContext) -> Result<()> {
         let mut sm = self.script_man_for_tv(ctx.config, &ctx.tv);
 
         for p in ctx.ts.list_paths(ctx.config) {
@@ -636,7 +643,7 @@ impl Plugin for ExternalPlugin {
         Ok(())
     }
 
-    fn uninstall_version(&self, config: &Config, tv: &ToolVersion) -> Result<()> {
+    fn uninstall_version_impl(&self, config: &Config, tv: &ToolVersion) -> Result<()> {
         if self.plugin_path.join("bin/uninstall").exists() {
             self.script_man_for_tv(config, tv)
                 .run(&config.settings, &Script::Uninstall)?;