perf(shell/zsh.rs): avoid hook-env execution on Enter without command (…

…#2861)

* perf(shell/zsh.rs): avoid hook-env execution on Enter without command

Some zsh configuration are intentionally optimized to work really fast and it's important to keep it feels this way. And while `mise hook-env` is really fast (0.008 sec on my system) and slowdown isn't noticeable when running any command (even builtin one like `echo` or `true`) it still result in _noticeable_ slowdown when just pressing Enter without any command.

At a glance proposed optimization shouldn't break any functionality, and it fixes mentioned above noticeable slowdown.

* fix(shell/zsh.rs): always trigger hook on cd

Fixes an issue when directory is changed after empty command (just Enter) using keyboard shortcut (e.g. Ctrl-PgUp/Down) instead of `cd` command - in this case hook wasn't triggered which result in showing other project's env variables to first command executed in non-project dir.

* fix(shell/zsh.rs): ensure hook-env will run on zsh start

This fixes two cases:
- Optimization bug: first command in a new shell won't get right env.
- Adds support for `zsh -i -c '...'` which also won't get right env.

* fix(shell/zsh.rs): deactivate _mise_hook_cmd

* fix(shell/zsh.rs): deactivate precmd_functions

* test: updated snapshots

---------

Co-authored-by: jdx <[email protected]>

src/cli/snapshots/mise__cli__deactivate__tests__deactivate-2.snap

@@ -1,10 +1,12 @@
 ---
 source: src/cli/deactivate.rs
 expression: output
+snapshot_kind: text
 ---
 export PATH='$PATH'
-precmd_functions=( ${precmd_functions:#_mise_hook} )
+precmd_functions=( ${precmd_functions:#_mise_hook_cmd} )
 chpwd_functions=( ${chpwd_functions:#_mise_hook} )
+unset -f _mise_hook_cmd
 unset -f _mise_hook
 unset -f mise
 unset MISE_SHELL

src/shell/snapshots/mise__shell__zsh__tests__activate.snap

@@ -1,6 +1,7 @@
 ---
 source: src/shell/zsh.rs
 expression: "zsh.activate(exe, \" --status\".into())"
+snapshot_kind: text
 ---
 export MISE_SHELL=zsh
 export __MISE_ORIG_PATH="$PATH"
@@ -29,9 +30,14 @@ mise() {
 _mise_hook() {
   eval "$(/some/dir/mise hook-env --status -s zsh)";
 }
+_mise_hook_cmd() {
+  if [[ -n "$ZLAST_COMMANDS" ]]; then
+    _mise_hook;
+  fi
+}
 typeset -ag precmd_functions;
-if [[ -z "${precmd_functions[(r)_mise_hook]+1}" ]]; then
-  precmd_functions=( _mise_hook ${precmd_functions[@]} )
+if [[ -z "${precmd_functions[(r)_mise_hook_cmd]+1}" ]]; then
+  precmd_functions=( _mise_hook_cmd ${precmd_functions[@]} )
 fi
 typeset -ag chpwd_functions;
 if [[ -z "${chpwd_functions[(r)_mise_hook]+1}" ]]; then

src/shell/snapshots/mise__shell__zsh__tests__deactivate.snap

@@ -1,9 +1,11 @@
 ---
 source: src/shell/zsh.rs
 expression: replace_path(&deactivate)
+snapshot_kind: text
 ---
-precmd_functions=( ${precmd_functions:#_mise_hook} )
+precmd_functions=( ${precmd_functions:#_mise_hook_cmd} )
 chpwd_functions=( ${chpwd_functions:#_mise_hook} )
+unset -f _mise_hook_cmd
 unset -f _mise_hook
 unset -f mise
 unset MISE_SHELL

src/shell/zsh.rs

@@ -44,9 +44,14 @@ impl Shell for Zsh {
             _mise_hook() {{
               eval "$({exe} hook-env{flags} -s zsh)";
             }}
+            _mise_hook_cmd() {{
+              if [[ -n "$ZLAST_COMMANDS" ]]; then
+                _mise_hook;
+              fi
+            }}
             typeset -ag precmd_functions;
-            if [[ -z "${{precmd_functions[(r)_mise_hook]+1}}" ]]; then
-              precmd_functions=( _mise_hook ${{precmd_functions[@]}} )
+            if [[ -z "${{precmd_functions[(r)_mise_hook_cmd]+1}}" ]]; then
+              precmd_functions=( _mise_hook_cmd ${{precmd_functions[@]}} )
             fi
             typeset -ag chpwd_functions;
             if [[ -z "${{chpwd_functions[(r)_mise_hook]+1}}" ]]; then
@@ -80,8 +85,9 @@ impl Shell for Zsh {
 
     fn deactivate(&self) -> String {
         formatdoc! {r#"
-        precmd_functions=( ${{precmd_functions:#_mise_hook}} )
+        precmd_functions=( ${{precmd_functions:#_mise_hook_cmd}} )
         chpwd_functions=( ${{chpwd_functions:#_mise_hook}} )
+        unset -f _mise_hook_cmd
         unset -f _mise_hook
         unset -f mise
         unset MISE_SHELL