Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activate: use full path to rtx #1170

Merged
merged 1 commit into from
Dec 14, 2023
Merged

activate: use full path to rtx #1170

merged 1 commit into from
Dec 14, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Dec 14, 2023

Copy link

github-actions bot commented Dec 14, 2023

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.12s
✅ BASH bash-exec 19 0 0.06s
✅ BASH shellcheck 19 0 0.49s
✅ BASH shfmt 19 0 0 0.04s
✅ DOCKERFILE hadolint 7 0 0.27s
✅ EDITORCONFIG editorconfig-checker 470 0 0.36s
✅ JSON eslint-plugin-jsonc 7 0 0 0.99s
✅ JSON jsonlint 6 0 0.13s
✅ JSON prettier 7 0 0 0.63s
✅ JSON v8r 7 0 4.37s
✅ MARKDOWN markdownlint 13 0 0 2.88s
❌ MARKDOWN markdown-link-check 13 1 29.45s
✅ MARKDOWN markdown-table-formatter 13 0 0 0.41s
✅ PYTHON bandit 1 0 0.71s
✅ PYTHON black 1 0 0 0.47s
✅ PYTHON flake8 1 0 0.5s
✅ PYTHON isort 1 0 0 0.36s
✅ PYTHON mypy 1 0 2.03s
✅ PYTHON pylint 1 0 1.3s
✅ PYTHON pyright 1 0 5.39s
✅ PYTHON ruff 1 0 0 0.1s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 2.11s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 2.38s
✅ REPOSITORY syft yes no 0.63s
✅ REPOSITORY trivy-sbom yes no 0.97s
✅ REPOSITORY trufflehog yes no 4.21s
✅ RUBY rubocop 2 0 0 5.46s
✅ RUST clippy yes no 102.63s
✅ XML xmllint 5 0 0 0.04s
✅ YAML prettier 12 0 0 1.15s
✅ YAML v8r 12 0 11.85s
✅ YAML yamllint 12 0 0.38s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@jdx jdx enabled auto-merge (squash) December 14, 2023 00:37
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8ccf67) 84.24% compared to head (f385c59) 80.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
- Coverage   84.24%   80.29%   -3.95%     
==========================================
  Files         136      136              
  Lines       12824    12827       +3     
==========================================
- Hits        10803    10299     -504     
- Misses       2021     2528     +507     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx force-pushed the activate-full-path branch 2 times, most recently from e4c804d to fd5bfdf Compare December 14, 2023 00:51
@jdx jdx force-pushed the activate-full-path branch from fd5bfdf to f385c59 Compare December 14, 2023 00:51
@jdx jdx disabled auto-merge December 14, 2023 00:57
@jdx jdx merged commit ac2d364 into main Dec 14, 2023
6 of 8 checks passed
@jdx jdx deleted the activate-full-path branch December 14, 2023 00:57
@karlbright
Copy link

Nice one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants