Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use trait object for progress bar wrappers #1182

Merged
merged 3 commits into from
Dec 14, 2023

gh

81ec42d
Select commit
Loading
Failed to load commit list.
Merged

refactor: use trait object for progress bar wrappers #1182

gh
81ec42d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 14, 2023 in 0s

81.69% (-0.02%) compared to 29d301d

View this Pull Request on Codecov

81.69% (-0.02%) compared to 29d301d

Details

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (29d301d) 81.70% compared to head (81ec42d) 81.69%.

Files Patch % Lines
src/ui/progress_report.rs 64.36% 31 Missing ⚠️
src/plugins/core/ruby.rs 0.00% 12 Missing ⚠️
src/plugins/core/node_build.rs 0.00% 10 Missing ⚠️
src/plugins/core/python.rs 0.00% 9 Missing ⚠️
src/plugins/core/node.rs 72.22% 5 Missing ⚠️
src/cli/prune.rs 0.00% 3 Missing ⚠️
src/ui/multi_progress_report.rs 71.42% 2 Missing ⚠️
src/cli/uninstall.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
- Coverage   81.70%   81.69%   -0.02%     
==========================================
  Files         136      136              
  Lines       12761    12787      +26     
==========================================
+ Hits        10427    10446      +19     
- Misses       2334     2341       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.