Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove shims directory from PATH when executing shims #2736

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

jdx
Copy link
Owner

@jdx jdx commented Oct 12, 2024

A follow-up to #2735 which was missing some cases

A follow-up to #2735 which was missing some cases
@jdx jdx enabled auto-merge (squash) October 12, 2024 19:00
@jdx jdx linked an issue Oct 12, 2024 that may be closed by this pull request
@jdx jdx merged commit a908a90 into main Oct 12, 2024
13 checks passed
@jdx jdx deleted the unshim branch October 12, 2024 19:06
Copy link

Code Coverage

Package Line Rate Complexity Health
src.backend 64% 0
src 86% 0
src.cli 78% 0
src.cli.alias 89% 0
src.cli.args 97% 0
src.cli.backends 95% 0
src.cli.cache 87% 0
src.cli.config 91% 0
src.cli.direnv 80% 0
src.cli.generate 72% 0
src.cli.plugins 84% 0
src.cli.settings 92% 0
src.cli.sync 56% 0
src.cli.tasks 75% 0
src.config.config_file 83% 0
src.config 85% 0
src.plugins 80% 0
src.plugins.core 55% 0
src.shell 98% 0
src.task 92% 0
src.toolset 83% 0
src.ui 66% 0
Summary 79% (15458 / 19659) 0

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.17% 5.56%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bb42307) 19665 15497 78.80%
Head commit (0ca5638) 19659 (-6) 15458 (-39) 78.63% (-0.17%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2736) 18 1 5.56%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shim hangs if npm backend tools are missing and node is managed by mise
1 participant