Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry): add aqua as primary backend for tools using ubi currently #3494

Closed
wants to merge 1 commit into from

Conversation

jimeh
Copy link
Contributor

@jimeh jimeh commented Dec 12, 2024

Add aqua as the primary backend for all possible tools that are using ubi as the primary backend currently.

This was achived by comparing mise registry and aqua list against each other with the following command:

comm -12 \
  <(mise registry | awk '{ print $2 }' | cut -d'[' -f1 | grep -E '^ubi:' | sed 's/^ubi://' | sort -u) \
  <(aqua list | cut -d',' -f2 | sort -u)

I have not tested all of these, so I sadly offer no guarantee every single tool installs correctly from aqua, but my assumption is that we assume aqua's registry works.

…ntly

Add aqua as the primary backend for all possible tools that are using
ubi as the primary backend currently.

This was achived by comparing `mise registry` and `aqua list` against
each other with the following command:

    comm -12 \
      <(mise registry | awk '{ print $2 }' | cut -d'[' -f1 | grep -E '^ubi:' | sed 's/^ubi://' | sort -u) \
      <(aqua list | cut -d',' -f2 | sort -u)
@jdx
Copy link
Owner

jdx commented Dec 12, 2024

well you certainly broke something given the test failures. If you want to do this you'll need to test one individually, we can't just assume they work.

@jimeh jimeh marked this pull request as draft December 12, 2024 10:43
@jdx
Copy link
Owner

jdx commented Dec 14, 2024

@jimeh I'm going to close just to keep things tidy, but if you want to pick this up again I'm happy to reopen

@jdx jdx closed this Dec 14, 2024
@jimeh
Copy link
Contributor Author

jimeh commented Dec 14, 2024

@jdx sure thing, I haven't gotten back around to looking at this properly, cause I'm having issues running the e2e tests locally on macOS (it either complains it can't find a mise executable, or complains mise is a macOS MachO executable).

I'll try in a VM when I have a chance, or digging deeper into what's causing the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants