Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort java versions alphanumerically (#928) #932

Closed
wants to merge 1 commit into from

Conversation

roele
Copy link
Contributor

@roele roele commented Oct 7, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ecc082f) 87.40% compared to head (810a035) 87.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #932   +/-   ##
=======================================
  Coverage   87.40%   87.41%           
=======================================
  Files         132      132           
  Lines       11596    11597    +1     
=======================================
+ Hits        10136    10137    +1     
  Misses       1460     1460           
Files Coverage Δ
src/plugins/core/java.rs 84.03% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx
Copy link
Owner

jdx commented Oct 7, 2023

I'm not willing to take on a dependency for this

@roele
Copy link
Contributor Author

roele commented Oct 7, 2023

Absolutely understand. Quite overkill for a cosmetic non-issue.

@jdx jdx linked an issue Oct 17, 2023 that may be closed by this pull request
@jdx jdx closed this Nov 9, 2023
@roele roele deleted the issue/928 branch January 6, 2024 21:33
jdx pushed a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java Temurin wrong version sort order
3 participants