Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xonsh hook #994

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix: xonsh hook #994

merged 1 commit into from
Nov 13, 2023

Conversation

CharString
Copy link
Contributor

It was raising a TypeError:

xonsh: For full traceback set: $XONSH_SHOW_TRACEBACK = True
TypeError: 'method' object is not subscriptable
Exception raised in event handler; ignored.

I was able to build, but running the tests failed with fatal runtime error: failed to initiate panic, error 5. I have been using the debug build and it solves the problems.

It was raising a TypeError:

```
xonsh: For full traceback set: $XONSH_SHOW_TRACEBACK = True
TypeError: 'method' object is not subscriptable
Exception raised in event handler; ignored.
```
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ff51d8) 87.44% compared to head (a26321e) 87.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files         132      132           
  Lines       11684    11684           
=======================================
  Hits        10217    10217           
  Misses       1467     1467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx merged commit 05e5630 into jdx:main Nov 13, 2023
17 checks passed
@jdx
Copy link
Owner

jdx commented Nov 13, 2023

thanks!

@CharString
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants