Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Galène with multilingual capacity #103

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

Mejans
Copy link

@Mejans Mejans commented Aug 26, 2021

This is just for the index.html page but the bases are here for i18n
The same logic has to be done with galene.html and 404.html

@Mejans Mejans mentioned this pull request Aug 26, 2021
@jech
Copy link
Owner

jech commented Aug 28, 2021

Please include the licensing information for simple-translator. Perhaps it should go into its own subdirectory of scripts/?
Please provide a clean patch series (use "git rebase -i" and "squash").

Where's the part that internationalises messages that come from Javascript?

@Mejans
Copy link
Author

Mejans commented Aug 28, 2021

Hello, it's not finished yet.
Will have to learn how to use "git rebase -i" and "squash". What JavaScript message?

@jech jech changed the title Galène with multilingual capacity WIP: Galène with multilingual capacity Aug 28, 2021
@jech
Copy link
Owner

jech commented Aug 28, 2021

it's not finished yet.

Ah, ok. Please remove « WIP » from the subject when you feel it's ready to review.

What JavaScript message?

A number of messages are generated by the Javascript code. Look at the calls to « displayError », for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants