-
Notifications
You must be signed in to change notification settings - Fork 353
Added request logging #35
base: master
Are you sure you want to change the base?
Conversation
Rejected -- I'm not going to help lazy sysadmins spy on their users. (A competent sysadmin should be able to patch Polipo himself.) |
Thank you, Heinrich! I do not believe in security by obscurity and thus will consider to include this in Debian. I find the arguments brought forth to reject this functionality inconsistent and unconvincing. |
@leggewie if you include this in Debian, make sure you protect against buffer overflows in |
I've changed my mind. Reopening. (But please fix the issues with your patch.) |
Can you elaborate on the buffer overflow issue? I can not see a problem there. |
This is awesome, addresses part of my logging desires for . Two requests:
I understand 2 may be additional work and understand if you cannot add it. I may take up that work and submit a PR for the cache HIT/MISS. Thanks for this PR, I merged them in to my local and they are working great. |
Sorry for the late reply. I'll look into this at the weekend. |
@HeinrichHartmann please check the result of |
Any progress on including this on debian? |
Added logging of all requests in the following form
$DATE - $METHOD - $URL
of levelINFO
e.g.Addresses #17.
Not sure if this is ready to merge.