Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] make PySide6 an optional dependency #346

Closed
jeertmans opened this issue Jan 4, 2024 · 0 comments · Fixed by #350
Closed

[FEATURE] make PySide6 an optional dependency #346

jeertmans opened this issue Jan 4, 2024 · 0 comments · Fixed by #350
Labels
enhancement New feature or request lib Related to the library (a.k.a. module) python Pull requests that update Python code qt Related to Qt (or its Python binding)

Comments

@jeertmans
Copy link
Owner

Description

Currently, PySide6 is a direct dependency and can cause issues when Manim Slides is installed on unsupported platforms by PySide6, like #345 or Python 3.12.

A suggestion might be to use qtpy and provide installation of the PySide6 backend using optional dependencies.

Screenshots

No response

Additional information

No response
@jeertmans jeertmans added enhancement New feature or request lib Related to the library (a.k.a. module) python Pull requests that update Python code qt Related to Qt (or its Python binding) labels Jan 4, 2024
@jeertmans jeertmans linked a pull request Jan 12, 2024 that will close this issue
chore(deps): make Qt backend optional #350
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request lib Related to the library (a.k.a. module) python Pull requests that update Python code qt Related to Qt (or its Python binding)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): make Qt backend optional jeertmans/manim-slides
1 participant
@jeertmans