chore(deps): make Qt backend optional #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeertmans
added
dependencies
jeertmans
had a problem deploying
to
github-pages
GitHub Actions
Error
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 80.33% 79.68% -0.65%
==========================================
Files 21 22 +1
Lines 1795 1797 +2
==========================================
- Hits 1442 1432 -10
- Misses 353 365 +12 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 12, 2024
This was
linked to
issues
Jan 12, 2024
TODO: - [ ] Add relevant entry in CHANGELOG - [ ] Update install documentation - [ ] Make sure `manim-slides convert` can run without any Qt backend - [ ] Make sure test suite works (partially) without any Qt backend - [ ] Make sure we can import `manim_slides` without any Qt backend
for more information, see https://pre-commit.ci
jeertmans
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jeertmans
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jeertmans
temporarily deployed
to
github-pages
GitHub Actions
Inactive
TODO: - [ ] Add relevant entry in CHANGELOG - [ ] Update install documentation - [ ] Make sure `manim-slides convert` can run without any Qt backend - [ ] Make sure test suite works (partially) without any Qt backend - [ ] Make sure we can import `manim_slides` without any Qt backend
for more information, see https://pre-commit.ci
jeertmans
had a problem deploying
to
github-pages
GitHub Actions
Error
jeertmans
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jeertmans
had a problem deploying
to
github-pages
GitHub Actions
Error
jeertmans
had a problem deploying
to
github-pages
GitHub Actions
Error
for more information, see https://pre-commit.ci
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
docs/source/installation.md
Outdated
|
|
||
| As of `v5.1`, you **need** to have Qt bindings installed to use | ||
| `manim-slides present` or `manim-slides wizard`. The recommended way to | ||
| install those is via optional dependencies, as explained above. |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
The verb ‘is’ is singular. Did you mean: “this is” or “those are”? (SINGULAR_VERB_AFTER_THESE_OR_THOSE[1])
Suggestions: this is, those are
Rule: https://community.languagetool.org/rule/show/SINGULAR_VERB_AFTER_THESE_OR_THOSE?lang=en-US&subId=1
Category: GRAMMAR
jeertmans
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jeertmans
had a problem deploying
to
github-pages
GitHub Actions
Error
jeertmans
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
manim-slides convertcan run without any Qt backendmanim_slideswithout any Qt backend