Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to work with Django 4 and a maintained IPFS library #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miguelgr
Copy link

@miguelgr miguelgr commented Mar 23, 2023

👋 Hi @jeffbr13, I am assuming you'd like to keep the project up to date but let me know.

I picked your project few days ago but it was completely outdated since the IPFS community/ecosystem is in constant change. Currently the only updated and working Python implementation of the API is IPFS-Toolkit.

Here is my working version in a Django project and the changes I've made:

  • Update Python's IPFS client library and IPFSStorage class.
  • Introduce tests (pytest), I haven't configured any CI since it would be nice to have with Github Actions in the original repo.
  • Modified minor things on readme and setup files.

🗒️ I kept the versioning in the package's __init__ but moved the storage code to its own module.

🍻 Cheers.

@@ -0,0 +1,26 @@
repos:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove this file but the use is a bunch of pre_commit hooks.
It requires having pre-commit but then just pre-commit install` to run the hooks before git commit.

@miguelgr miguelgr force-pushed the upgrade/requirements branch 2 times, most recently from 20a0b5f to 4d3ad82 Compare March 29, 2023 08:31
Update Python's IPFS client library
Add tests (pytest)
Modified minor things on readme and setup files
@miguelgr miguelgr force-pushed the upgrade/requirements branch from 4d3ad82 to 08d3a3e Compare March 29, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant