Modernize Build... #134

lishaduck · 2024-11-30T04:52:42Z

I just wanted an esm dist to make it debuggable...

Summary:

Fixed a typo...
Distributing ESM (non-breaking, as there isn't an API. Well, there technically was, but a quick search showed nobody used it, and it didn't seem like Please verify that the package.json has a valid "main" entry #90 wanted an API?)
Build with Rolldown (via tsdown), isolated declaration emit using oxc
ESLint 9 + flat config
Vitest

~~Might break node 16?~~ (Yeah, rolldown doesn't support 16)

Summary part 2:

Tune Vitest settings
Fix Monorepo support (allegedly) broken on Windows #131
A few small refactors
Use tinyglobby instead of globby.
Update readme (@jeffijoe, may I suggest rerecording the gif sometime?)

Summary pt. 3

ESM-only bumps
Fix bug cwd bug
More cleanup

I just wanted an esm dist to make it debuggable...

coveralls · 2024-11-30T05:09:03Z

coverage: 100.0%. remained the same
when pulling d526f9d on lishaduck:modernize
into e7fdd3e on jeffijoe:master.

jeffijoe

This is awesome!

src/__tests__/cli-util.test.ts

lishaduck · 2024-11-30T21:24:15Z

Sooo... I was stuck in a car for a 7 hours today (post-holiday traffic jams b/c snow) and was sorta bored...
Time for a push! I kinda fixed #131 and refactored the rest of everything in the process.

EDIT: Interactive rebasing to make the commits easier to review.

Vitest's inference isn't as good, unfortunately.

Tests now fail if they don't explicitly test anything.

`fakes.ts` no longer exists and `types.ts` is fully tested (somehow).

Drop `filterMap` in favor of the `flatMap` method. Prefer the `includes` method. Replace sole source of mutability with a ternary.

We only write nice, pure functions that don't use classy state. If we let ts know, it'll stop complaining sometimes. We've already done it elsewhere, this just makes it consistent.

Glob provides a root option, which we should use instead of `join`. Why? `join` will normalize it to a Windows path. node-glob only takes POSIX paths, so we can't use `join`. Fixes jeffijoe#131.

This is explicitly warned against in the Node documentation, to the point that Deno doesn't even support doing this (easily). This is also a potential bug Windows bug as well. And best part of all: the new code is shorter!

And squeeze out some optimizations in globbing. We can glob for all of the patterns at once, and also ignore the ignored workspaces to reduce i/o.

lishaduck · 2024-11-30T22:03:28Z

Here ya go. Hopefully the rebase didn't break anything.

Cool, just need to fix that coverage real quick!

lishaduck · 2024-11-30T22:11:28Z

Sorry for making you have to review this...

src/fs-utils.ts

lishaduck · 2024-12-01T00:05:15Z

Yeah, but I don't have the typesync installed on my windows VM, just sheriff for the repro.

jeffijoe · 2024-12-01T00:12:58Z

[email protected]

lishaduck · 2024-12-01T00:48:37Z

Ok, glad I tested. Something broke (yes, it's that slow)

lishaduck · 2024-12-01T02:09:51Z

🤦‍♂️ onlyfiles is true by default.

Tinyglobby's defaults are based on fast-glob.

lishaduck · 2024-12-01T02:14:35Z

Ok, this PR is good, but I found another bug, I'll probably push the fix if I find the issue.

It doesn't seem to be installed anymore?

lishaduck

Fixed the bug, CI's green.

src/cli.ts

lishaduck · 2024-12-01T18:23:25Z

I was thinking about this and realized I'd thought of another bug in paths, which fixing should give a nice perf boost, so I'm going to do it.

Otherwise, `readFileContents` doesn't work as expected.

package.json

Can bump with Node 18.

jeffijoe · 2024-12-02T10:54:58Z

Lmk when you're done and I'll merge 👍

lishaduck · 2024-12-02T13:25:36Z

I'm done.

jeffijoe · 2024-12-02T14:01:23Z

Released as 0.14, thanks @lishaduck !

lishaduck added 2 commits November 29, 2024 22:49

feat: modernize

2d4e811

I just wanted an esm dist to make it debuggable...

ci: see if green w/out 16

16f358c

lishaduck force-pushed the modernize branch from 618e79a to 16f358c Compare November 30, 2024 05:07

ci: add 22 to matrix

0016f81

fix: use tilde ranges for DefinitelyTyped

b8a2f78

jeffijoe approved these changes Nov 30, 2024

View reviewed changes

src/__tests__/cli-util.test.ts Show resolved Hide resolved

lishaduck added 17 commits November 30, 2024 15:46

fix: constrain engines to eslint-compatible versions

dbbd72f

chore: use json modules instead of require(json)

d84285c

chore: remove redundant mocks

ef1e97f

fix: reset mocks after tests

07cc2b9

fix: type mocks

ee1e104

Vitest's inference isn't as good, unfortunately.

chore: enable requireAssertions for tests

956734b

Tests now fail if they don't explicitly test anything.

chore: update coverage ignores

08f2bea

`fakes.ts` no longer exists and `types.ts` is fully tested (somehow).

chore: enable vitest ui

c5add31

refactor: array operations

b629ef8

Drop `filterMap` in favor of the `flatMap` method. Prefer the `includes` method. Replace sole source of mutability with a ternary.

fix: mark methods as pure functions

6499bdc

We only write nice, pure functions that don't use classy state. If we let ts know, it'll stop complaining sometimes. We've already done it elsewhere, this just makes it consistent.

fix: windows root

f08956d

Glob provides a root option, which we should use instead of `join`. Why? `join` will normalize it to a Windows path. node-glob only takes POSIX paths, so we can't use `join`. Fixes jeffijoe#131.

fix: race condition

404de28

This is explicitly warned against in the Node documentation, to the point that Deno doesn't even support doing this (easily). This is also a potential bug Windows bug as well. And best part of all: the new code is shorter!

docs: rephrase comment

4144051

refactor: use tinyglobby

278d3bc

And squeeze out some optimizations in globbing. We can glob for all of the patterns at once, and also ignore the ignored workspaces to reduce i/o.

style: remove underscore from name

1257d5f

style: remove redundant parameters

0b055e8

refactor: make test more concurrent

ea631a0

lishaduck force-pushed the modernize branch from 1895b30 to da01b56 Compare November 30, 2024 22:03

lishaduck marked this pull request as ready for review November 30, 2024 22:11

jeffijoe approved these changes Nov 30, 2024

View reviewed changes

src/fs-utils.ts Show resolved Hide resolved

fix: tinyglobby path

4107ebd

Tinyglobby's defaults are based on fast-glob.

lishaduck added 6 commits November 30, 2024 20:46

fix: use a directory in test

48c3507

refactor: clarify glob functionality

bcb0c28

refactor: move ensureWorkspacesArray function to workspace-resolver

ba79fd0

chore: add build:watch script to package.json

0c6af43

chore: remove lint-staged configuration from package.json

d0221c4

It doesn't seem to be installed anymore?

fix: handle workspaces when root isn't cwd

050746a

lishaduck force-pushed the modernize branch from 90729c8 to 050746a Compare December 1, 2024 05:22

lishaduck commented Dec 1, 2024

View reviewed changes

jeffijoe reviewed Dec 1, 2024

View reviewed changes

src/cli.ts Show resolved Hide resolved

lishaduck added 3 commits December 1, 2024 12:45

fix: enforce async rules

61a4cfa

Otherwise, `readFileContents` doesn't work as expected.

perf: tinyglobby takes patterns for ignores

09a8ed5

refactor: expect rejection

6716a53

lishaduck commented Dec 1, 2024

View reviewed changes

package.json Show resolved Hide resolved

lishaduck added 3 commits December 1, 2024 22:40

ci: don't run fixes in ci

41c380e

style: format utils

290e888

chore: update es version

d526f9d

Can bump with Node 18.

jeffijoe approved these changes Dec 2, 2024

View reviewed changes

jeffijoe merged commit ff6be67 into jeffijoe:master Dec 2, 2024
5 checks passed

lishaduck deleted the modernize branch December 2, 2024 13:40

jeffijoe mentioned this pull request Dec 11, 2024

'ERR_UNKNOWN_FILE_EXTENSION' #136

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernize Build... #134

Modernize Build... #134

lishaduck commented Nov 30, 2024 •

edited

Loading

coveralls commented Nov 30, 2024 •

edited

Loading

jeffijoe left a comment

lishaduck commented Nov 30, 2024 •

edited

Loading

lishaduck commented Nov 30, 2024 •

edited

Loading

lishaduck commented Nov 30, 2024

lishaduck commented Dec 1, 2024

jeffijoe commented Dec 1, 2024

lishaduck commented Dec 1, 2024 •

edited

Loading

lishaduck commented Dec 1, 2024

lishaduck commented Dec 1, 2024

lishaduck left a comment

lishaduck commented Dec 1, 2024

jeffijoe commented Dec 2, 2024

lishaduck commented Dec 2, 2024

jeffijoe commented Dec 2, 2024

Modernize Build... #134

Modernize Build... #134

Conversation

lishaduck commented Nov 30, 2024 • edited Loading

coveralls commented Nov 30, 2024 • edited Loading

jeffijoe left a comment

Choose a reason for hiding this comment

lishaduck commented Nov 30, 2024 • edited Loading

lishaduck commented Nov 30, 2024 • edited Loading

lishaduck commented Nov 30, 2024

lishaduck commented Dec 1, 2024

jeffijoe commented Dec 1, 2024

lishaduck commented Dec 1, 2024 • edited Loading

lishaduck commented Dec 1, 2024

lishaduck commented Dec 1, 2024

lishaduck left a comment

Choose a reason for hiding this comment

lishaduck commented Dec 1, 2024

jeffijoe commented Dec 2, 2024

lishaduck commented Dec 2, 2024

jeffijoe commented Dec 2, 2024

lishaduck commented Nov 30, 2024 •

edited

Loading

coveralls commented Nov 30, 2024 •

edited

Loading

lishaduck commented Nov 30, 2024 •

edited

Loading

lishaduck commented Nov 30, 2024 •

edited

Loading

lishaduck commented Dec 1, 2024 •

edited

Loading