allow clicking on notification to open url

jeffvli · Mar 28, 2024 · ef58851 · ef58851
1 parent 842e5ff
commit ef58851
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/i18n/locales/en.json b/src/i18n/locales/en.json
@@ -256,7 +256,7 @@
             "allowDownloading": "allow downloading",
             "description": "description",
             "setExpiration": "set expiration",
-            "success": "share link copied to clipboard",
+            "success": "share link copied to clipboard (or click here to open)",
             "expireInvalid": "expiration must be in the future",
             "createFailed": "failed to create share (is sharing enabled?)"
         },

diff --git a/src/renderer/features/sharing/components/share-item-context-modal.tsx b/src/renderer/features/sharing/components/share-item-context-modal.tsx
@@ -63,11 +63,25 @@ export const ShareItemContextModal = ({
                 onSuccess: (_data) => {
                     if (!server) throw new Error('Server not found');
                     if (!_data?.id) throw new Error('Failed to share item');
-                    navigator.clipboard.writeText(`${server.url}/share/${_data.id}`);
+
+                    const shareUrl = `${server.url}/share/${_data.id}`;
+
+                    navigator.clipboard.writeText(shareUrl);
                     toast.success({
+                        autoClose: 5000,
+                        id: 'share-item-toast',
                         message: t('form.shareItem.success', {
                             postProcess: 'sentenceCase',
                         }),
+                        onClick: (a) => {
+                            if (!(a.target instanceof HTMLElement)) return;
+
+                            // Make sure we weren't clicking close (otherwise clicking close /also/ opens the url)
+                            if (a.target.nodeName !== 'svg') {
+                                window.open(shareUrl);
+                                toast.hide('share-item-toast');
+                            }
+                        },
                     });
                 },
             },