Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix portrait mode detection #582

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Fix portrait mode detection #582

merged 2 commits into from
Apr 17, 2024

Conversation

Kaydax
Copy link
Contributor

@Kaydax Kaydax commented Apr 11, 2024

For some reason it was hard coded to only switch to portrait mode when the window width is less-than or equal to 768px.

This was a very simple fix and seems to work perfectly fine after testing it for a bit with multiple window sizes.

@vercel Vercel
Copy link

vercel bot commented Apr 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
feishin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 2:01pm

@kgarner7 kgarner7 requested a review from jeffvli April 16, 2024 03:43
kgarner7
kgarner7 requested changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@kgarner7 kgarner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! While detecting orientation for the full screen player and related components probably makes sense, I'd disagree that you should also apply the same changes to the playbar, which is just width-based

src/renderer/features/player/components/center-controls.tsx Outdated
@@ -63,7 +63,7 @@ const SliderValueWrapper = styled.div<{ $position: 'left' | 'right' }>`
justify-content: center;
max-width: 50px;

@media (width <= 768px) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be based on width alone (not orientation)

src/renderer/features/player/components/center-controls.tsx Outdated
@@ -81,7 +81,7 @@ const ControlsContainer = styled.div`
justify-content: center;
height: 35px;

@media (width <= 768px) {
@media (orientation: portrait) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

src/renderer/features/player/components/playerbar.tsx Outdated
@@ -30,7 +30,7 @@ const PlayerbarControlsGrid = styled.div`
gap: 1rem;
height: 100%;

@media (width <= 768px) {
@media (orientation: portrait) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

src/renderer/features/shared/components/library-header.module.scss Outdated
@@ -58,7 +58,7 @@
}
}

@container (min-width: 768px) {
@container (orientation: portrait) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@Kaydax Kaydax requested a review from kgarner7 April 16, 2024 14:09
@kgarner7 kgarner7 merged commit 04b4d92 into jeffvli:development Apr 17, 2024
2 checks passed
spiceratops referenced this pull request in spiceratops/k8s-gitops May 7, 2024
@spiceratops
feat(container): update image ghcr.io/jeffvli/feishin to v0.7.1 (#738)
d5d1599 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/jeffvli/feishin](https://togithub.com/jeffvli/feishin) |
minor | `0.6.1` -> `0.7.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>jeffvli/feishin (ghcr.io/jeffvli/feishin)</summary>

###
[`v0.7.1`](https://togithub.com/jeffvli/feishin/releases/tag/v0.7.1):
0.7.1

[Compare
Source](https://togithub.com/jeffvli/feishin/compare/v0.7.0...v0.7.1)

0.7.1 released to fix missing Windows binary.

**Full Changelog**:
jeffvli/feishin@v0.7.0...v0.7.1

###
[`v0.7.0`](https://togithub.com/jeffvli/feishin/releases/tag/v0.7.0):
0.7.0

[Compare
Source](https://togithub.com/jeffvli/feishin/compare/v0.6.1...v0.7.0)

0.7.0 is here!

Moving forwards, release notes will be simplified as so. Thanks to all
the contributors as always!

#### Highlights

- (UI) Added `Get Info` button on dropdowns to show extended details for
the selected item
-   (UI) Changed titlebar on light theme to use a lighter color
- (UI) Error page now shows server menu in case to handle cases where
application can become stuck
- (UI) Fixed synchronized lyrics not repeating when track is repeated on
fullscreen player
- (UI) Added toggle to switch between tracks and albums when double
clicking an item in the genres list
-   (UI) (Jellyfin) Fixed lyrics parsing for Jellyfin v10.9.0
-   (UI) (Navidrome) Adds `Share item` to item context menus
- (UI) (Navidrome) Added `inPlaylist` and `notInPlaylist` operators for
Navidrome smart playlists
- (UI) (Navidrome) Added JSON preview for smart playlist builder output
- (UI) Added Farsi and Chinese (Traditional) languages (thanks to
translators!)
- (Desktop) The positioning state of the application is now persisted
(maximize, fullscreen, window position)
- (Player) Various fixes/improvements with player implementation
including mpris and scrobbling
- ...and more: [view
commits](https://togithub.com/jeffvli/feishin/compare/v0.6.1...v0.7.0)

#### What's Changed

- Bump the npm_and_yarn group across 1 directory with 2 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/jeffvli/feishin/pull/542](https://togithub.com/jeffvli/feishin/pull/542)
- Bump the npm_and_yarn group across 1 directory with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/jeffvli/feishin/pull/551](https://togithub.com/jeffvli/feishin/pull/551)
- Bump the npm_and_yarn group across 1 directory with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/jeffvli/feishin/pull/557](https://togithub.com/jeffvli/feishin/pull/557)
- Bump the npm_and_yarn group across 1 directory with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/jeffvli/feishin/pull/561](https://togithub.com/jeffvli/feishin/pull/561)
- \[bugfix]: Resolve MPV next/prev race condition by
[@&#8203;kgarner7](https://togithub.com/kgarner7) in
[https://github.com/jeffvli/feishin/pull/566](https://togithub.com/jeffvli/feishin/pull/566)
- \[bugfix]: Add a fallback image to the dynamic background url by
[@&#8203;iiPythonx](https://togithub.com/iiPythonx) in
[https://github.com/jeffvli/feishin/pull/571](https://togithub.com/jeffvli/feishin/pull/571)
- \[enhancement]: Show item details by
[@&#8203;kgarner7](https://togithub.com/kgarner7) in
[https://github.com/jeffvli/feishin/pull/573](https://togithub.com/jeffvli/feishin/pull/573)
- Fix portrait mode detection by
[@&#8203;Kaydax](https://togithub.com/Kaydax) in
[https://github.com/jeffvli/feishin/pull/582](https://togithub.com/jeffvli/feishin/pull/582)
- \[enhancement]: Support react-router links in Modal by
[@&#8203;kgarner7](https://togithub.com/kgarner7) in
[https://github.com/jeffvli/feishin/pull/586](https://togithub.com/jeffvli/feishin/pull/586)
- \[enhancement]: Support toggling Album/Track view for gneres by
[@&#8203;kgarner7](https://togithub.com/kgarner7) in
[https://github.com/jeffvli/feishin/pull/591](https://togithub.com/jeffvli/feishin/pull/591)
- Implement Navidrome sharing by
[@&#8203;iiPythonx](https://togithub.com/iiPythonx) in
[https://github.com/jeffvli/feishin/pull/575](https://togithub.com/jeffvli/feishin/pull/575)
- \[bugfix]: Handle top-level songs for Jellyfin by
[@&#8203;kgarner7](https://togithub.com/kgarner7) in
[https://github.com/jeffvli/feishin/pull/553](https://togithub.com/jeffvli/feishin/pull/553)
- Bump ejs from 3.1.9 to 3.1.10 in the npm_and_yarn group across 1
directory by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/jeffvli/feishin/pull/602](https://togithub.com/jeffvli/feishin/pull/602)
- Fix LrcLib fetcher by
[@&#8203;vukanovics](https://togithub.com/vukanovics) in
[https://github.com/jeffvli/feishin/pull/603](https://togithub.com/jeffvli/feishin/pull/603)
- Allow smaller album covers in card/poster display by
[@&#8203;Dylancyclone](https://togithub.com/Dylancyclone) in
[https://github.com/jeffvli/feishin/pull/598](https://togithub.com/jeffvli/feishin/pull/598)
- Add new Navidrome smart playlist operators (up to v0.52.0) by
[@&#8203;jeffvli](https://togithub.com/jeffvli) in
[https://github.com/jeffvli/feishin/pull/604](https://togithub.com/jeffvli/feishin/pull/604)

#### New Contributors

- [@&#8203;Kaydax](https://togithub.com/Kaydax) made their first
contribution in
[https://github.com/jeffvli/feishin/pull/582](https://togithub.com/jeffvli/feishin/pull/582)
- [@&#8203;vukanovics](https://togithub.com/vukanovics) made their first
contribution in
[https://github.com/jeffvli/feishin/pull/603](https://togithub.com/jeffvli/feishin/pull/603)
- [@&#8203;Dylancyclone](https://togithub.com/Dylancyclone) made their
first contribution in
[https://github.com/jeffvli/feishin/pull/598](https://togithub.com/jeffvli/feishin/pull/598)

**Full Changelog**:
jeffvli/feishin@v0.6.1...v0.7.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDcuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM0OC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffvli jeffvli Awaiting requested review from jeffvli

@kgarner7 kgarner7 Awaiting requested review from kgarner7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kaydax @kgarner7