Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rake 13 to fix master #381

Merged
merged 2 commits into from
Dec 31, 2022
Merged

Upgrade to Rake 13 to fix master #381

merged 2 commits into from
Dec 31, 2022

Conversation

jez
Copy link
Contributor

@jez jez commented Dec 30, 2022

I had a CI run fail for #379 which looks like a failure in the "setup ruby" step.

I'm not sure how the changes I made in #379 could have caused that problem—it fails even before attempting to run the tests, and I haven't touched anything related to dependencies.

I'm trying to figure out whether my intuition is incorrect, or whether CI is actually failing on master. I notice that the last master change was from a couple months ago, so I'm worried that some dependency has broken in the mean time.

@ashmaroli
Copy link
Member

If you look at the log report, you'll see that the error is from gem sass-embedded which is a recent entry into our bundle via jekyll-sass-converter-3.0.
So, the master is most likely affected as well. However, what puzzles me is that the error doesn't occur at repo jekyll/jekyll for same Ruby version. Maybe I am overlooking something obvious...

@jez
Copy link
Contributor Author

jez commented Dec 31, 2022

One thing I noticed when I was working locally (that I managed to deal with separately) was this message:

❯ bundle update
Fetching https://github.com/jez/jekyll-feed.git
Fetching gem metadata from https://rubygems.org/..........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
sass-embedded-1.57.1-x86_64-linux-gnu requires rubygems version >= 3.3.22, which is incompatible with the current version, 3.1.6

I wonder if the bug is that sass-embedded made a change that tied them to a specific bundler version, and only later realized that they should declare that dependency in a version bound?

I wonder if it's possible to fix CI by pinning the sass-embedded version in CI somehow? I still haven't managed to exactly reproduce the failure as seen by CI in my local environment.

(Thanks for taking a moment to look at this.)

@ashmaroli
Copy link
Member

That's a different issue @jez. Its asking for a newer version of Rubygems, not Bundler.
You can update the version on your local system by running:

gem update --system

Could you add a commit bumping gem "rake" to use "~> 13.0" on this branch? Please ping me after you push so that I can activate the CI run.

@parkr
Copy link
Member

parkr commented Dec 31, 2022

Interesting. Is Rake 12 incompatible with certain features of Ruby 3? I'm surprised we didn't catch this before.

@jez
Copy link
Contributor Author

jez commented Dec 31, 2022

@ashmaroli lmk if the latest commit is what you're looking for

@ashmaroli
Copy link
Member

@parkr I'm not sure if Rake 12.x is incompatible with Ruby 3, but gem sass-embedded seems to be using a syntax that is not compatible with Rake 12.
We didn't catch this before because Jekyll Core had moved onto Rake 13 long ago and that sass-embedded only became a default member of our bundle / gemset recently.

@ashmaroli
Copy link
Member

@jez CI is passing.
So your mission has been successful. 🙂

@jez jez changed the title wip: Testing CI Upgrade to Rake 13 to fix master Dec 31, 2022
@jez jez marked this pull request as ready for review December 31, 2022 08:35
@parkr
Copy link
Member

parkr commented Dec 31, 2022

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit f0669f6 into jekyll:master Dec 31, 2022
jekyllbot added a commit that referenced this pull request Dec 31, 2022
@ashmaroli
Copy link
Member

@parkr Do we really need Rake for this repository?

@jez jez deleted the jez-test branch December 31, 2022 18:00
emmahsax pushed a commit to emmahsax/jekyll-feed that referenced this pull request Feb 10, 2023
@jekyll jekyll locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants