-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Rake 13 to fix master #381
Conversation
If you look at the log report, you'll see that the error is from gem |
One thing I noticed when I was working locally (that I managed to deal with separately) was this message:
I wonder if the bug is that I wonder if it's possible to fix CI by pinning the (Thanks for taking a moment to look at this.) |
That's a different issue @jez. Its asking for a newer version of Rubygems, not Bundler.
Could you add a commit bumping gem "rake" to use |
Interesting. Is Rake 12 incompatible with certain features of Ruby 3? I'm surprised we didn't catch this before. |
@ashmaroli lmk if the latest commit is what you're looking for |
@parkr I'm not sure if Rake 12.x is incompatible with Ruby 3, but gem |
@jez CI is passing. |
@jekyllbot: merge +dev |
@parkr Do we really need Rake for this repository? |
I had a CI run fail for #379 which looks like a failure in the "setup ruby" step.
I'm not sure how the changes I made in #379 could have caused that problem—it fails even before attempting to run the tests, and I haven't touched anything related to dependencies.
I'm trying to figure out whether my intuition is incorrect, or whether CI is actually failing on master. I notice that the last master change was from a couple months ago, so I'm worried that some dependency has broken in the mean time.