[WIP][POC] update swiftfin tvos signin #1113
Conversation
Isaiah-Hamilton
changed the title
| HStack(alignment: .top) { | ||
| VStack(alignment: .leading) { | ||
| signInSection | ||
| VStack { |
There was a problem hiding this comment.
Thank you for fixing the buttons, but this needs to be in a HStack like before. This is a deliberate design decision for these being different sections, and they should be equally sized. Additionally, the public user section can be of any size and requiring to scroll through them isn't desirable.
|
Hi @Isaiah-Hamilton, I hope you’re doing well! I just wanted to check in to see if you’re still interested in working on this. I’ve been revisiting some tvOS features recently, and I think there’s some potential for refining this However, if you’re a bit busy or prefer someone else to take it on, I’d be happy to help out or even pick it up from here! This is the latest version I was working on based on @LePips feedback:
I'd be happy to share this code as well! Let me know your thoughts! 😊 |
|
@JPKribs I'm a little to busy at the moment to work on this, but I would be happy to pass this over to someone else. Though I would still like to be kept in the loop/have to some input on somethings. So far what you have is great, and think we should go based on what you have currently. |
Sounds good! Thanks for getting the ball rolling. I have my branch of this here: #1365 Let me know if you have any feedback! I found that the |
|
This work has been merged in via #1365, so I am going to close this out. Thank you again for getting the ball rolling with this SignIn cleanup, @Isaiah-Hamilton! |
Changes made
Updated the swiftfin tvos signin view
Before
After
Feedback
Let me know which one is best and what you think.