Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [tvOS] Letter Picker #1177

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Aug 9, 2024

Summary

Takes the same logic from the LetterPickerBar on iOS and implements it to tvOS.

Image

Simulator Screenshot - Apple TV 4K (3rd generation) - 2024-08-09 at 14 04 11

Video
Simulator.Screen.Recording.-.Apple.TV.4K.3rd.generation.-.2024-08-09.at.14.04.40.mp4

Outstanding Issues

  1. On Main, tvOS PagingScrollViews jump their focus to the top of the page whenever a new page of data is loaded. Since the Letter Picker is the tallest item, this is now capturing the focus. I think this is more of an issue with the PagingLibraryView and knocking out that TODO. (I tried but I couldn't get figure it out)
  2. If you are hovering a letter that is above, below, or between posters, it cannot jump to them. Instead, you have to go back up to a letter that in even to a poster to move the cursor back to the posters.
  3. This only works where there are filterViewModels. This means the MainTab Movies/TV Shows cannot have a Letter Picker on them. Only items in Media section can have it. I didn't want to dig too far into adding FilterViewModels to the ItemTypeLibraries. Partially because I'm not sure how but also do we want the Item Types to have filters on them?

Outstanding Discussions

  • I made the letters white with a shadow for visibility. Let me know if there are any issues with this.
  • Since I am able to re-use the LetterPickerBar, I moved this to Shared but the LetterPickerButtons are OS specific. Let me know if it would be better to have a separate bar per OS.

@LePips
Copy link
Member

LePips commented Aug 24, 2024

I won't be looking at tvOS for a bit and will have to think about the design and interaction of this.

@JPKribs JPKribs added enhancement New feature or request and removed enhancement New feature or request labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants