Remove unused Id prop from access schedule list #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cloudflare Pages deployment
|
|
Supersedes #4902 |
thornbill
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by sonarcloud: https://sonarcloud.io/project/issues?fileUuids=AX6fELCkjUUWs1HF_Tc8&resolved=false&types=CODE_SMELL&id=jellyfin_jellyfin-web&open=AYr_7x6Y4nroI6nze3Zu
Changes
Recommendations for First Time Contributors suggests fixing code smells listed on SonarCloud. The fixed smell is an unused React prop on the
AccessScheduleListcomponent. After confirming it was unused, I removed it from the interface and the sole reference to that prop from theUserParentalControlcomponent. Building produced no errors, all vitest tests passed locally, and the parental control schedule seemed to have no regressions in my manual test in the browser.The Contributing docs also say to add your name to the contribution markdown file, so I included that in my commit.
Issues
No GitHub issues resolved, but the following SonarCloud code smell will be resolved: https://sonarcloud.io/project/issues?fileUuids=AX6fELCkjUUWs1HF_Tc8&resolved=false&types=CODE_SMELL&id=jellyfin_jellyfin-web&open=AYr_7x6Y4nroI6nze3Zu